Skip to content

Fix incorrect DNS instructions #37728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix incorrect DNS instructions #37728

wants to merge 1 commit into from

Conversation

vladh
Copy link
Contributor

@vladh vladh commented Apr 23, 2025

Why:

The previous instructions incorrectly implied that users should choose one of A, AAAA and ALIAS/ANAME records. In fact, if users do not opt for the ALIAS/ANAME record, they should use both A and AAAA records. This change makes that clearer.

(There is no issue for this change. I decided not to open one, because this is a minor change.)

What's being changed (if available, include any code snippets, screenshots, or gifs):

(This is trivially visible in the diff.)

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

The previous instructions incorrectly implied that users should choose _one_ of `A`, `AAAA` and `ALIAS`/`ANAME` records. In fact, if users do not opt for the `ALIAS`/`ANAME` record, they should use _both_ `A` and `AAAA` records. This change makes that clearer.
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Apr 23, 2025
Copy link
Contributor

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

⚠️ Warning: Our review server is experiencing latency issues.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on the review server. Changes to the data directory are not included in this table.

Source Review Production What Changed
pages/configuring-a-custom-domain-for-your-github-pages-site/managing-a-custom-domain-for-your-github-pages-site.md fpt
ghec
fpt
ghec

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

@changeschung

This comment was marked as spam.

@Sharra-writes
Copy link
Contributor

Thanks for opening a PR! I'll get this triaged for review.

@Sharra-writes Sharra-writes added content This issue or pull request belongs to the Docs Content team pages Content related to GitHub Pages needs SME This proposal needs review from a subject matter expert and removed triage Do not begin working on this issue until triaged by the team labels Apr 23, 2025
Copy link
Contributor

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert pages Content related to GitHub Pages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants