Skip to content

Fix VS Code inputs link #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

Fix VS Code inputs link #103

merged 1 commit into from
Apr 4, 2025

Conversation

digitarald
Copy link
Member

Without it VS Code will show an error

@Copilot Copilot AI review requested due to automatic review settings April 4, 2025 16:40
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses an issue in VS Code where an error is displayed due to misconfigured input parameters in the install links.

  • Updated the install links in README.md for both VS Code and VS Code Insiders by adding the "type": "promptString" property.
  • The changes ensure that VS Code correctly recognizes the GitHub Personal Access Token input.
Comments suppressed due to low confidence (1)

README.md:7

  • Please verify that using the 'insiders.vscode.dev' domain for the VS Code badge is intentional; if this link is meant for the stable VS Code version, it should point to the appropriate vscode.dev URL.
[![Install with Docker in VS Code](https://img.shields.io/badge/VS_Code-Install_Server-0098FF?style=flat-square&logo=visualstudiocode&logoColor=white)](https://insiders.vscode.dev/redirect/mcp/install?name=github&inputs=%5B%7B%22id%22%3A%22github_token%22%2C%22type%22%3A%22promptString%22%2C%22description%22%3A%22GitHub%20Personal%20Access%20Token%22%2C%22password%22%3Atrue%7D%5D&config=%7B%22command%22%3A%22docker%22%2C%22args%22%3A%5B%22run%22%2C%22-i%22%2C%22--rm%22%2C%22-e%22%2C%22GITHUB_PERSONAL_ACCESS_TOKEN%22%2C%22ghcr.io%2Fgithub%2Fgithub-mcp-server%22%5D%2C%22env%22%3A%7B%22GITHUB_PERSONAL_ACCESS_TOKEN%22%3A%22%24%7Binput%3Agithub_token%7D%22%7D%7D)

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

Copy link
Collaborator

@williammartin williammartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Insiders link works for me now.

@toby toby merged commit 92303d4 into main Apr 4, 2025
14 checks passed
@toby toby deleted the digitarald-patch-1 branch April 4, 2025 17:20
manian0430 pushed a commit to ChrisLally/github-mcp-server that referenced this pull request Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants