Skip to content

update install instructions #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

update install instructions #43

merged 2 commits into from
Mar 27, 2025

Conversation

juruen
Copy link
Collaborator

@juruen juruen commented Mar 26, 2025

Context

Update doc on how to install and test this out in VS insiders. Show Docker option as the first choice to do so.

As variable inputs don't seem to work to introduce the token, we remove that from the README until they work.

@juruen juruen marked this pull request as ready for review March 26, 2025 15:35
@Copilot Copilot AI review requested due to automatic review settings March 26, 2025 15:35
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the install instructions in the README to include a Docker-based installation option as the primary method, while also providing steps for building the binary from the repo. Key changes include the addition of Docker image requirements and updated configuration instructions for starting VS Code Insiders.

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@juruen juruen force-pushed the juruen/update-instructions branch 2 times, most recently from 42b407c to c402539 Compare March 26, 2025 15:36
@juruen juruen force-pushed the juruen/update-instructions branch from c402539 to cda36e8 Compare March 26, 2025 15:39
@juruen juruen requested a review from Copilot March 26, 2025 15:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the install instructions in the README to reflect the new installation options for VS Code Insiders, with a focus on the Docker image option and the removal of variable token inputs.

  • Added a Docker image installation section with authentication instructions.
  • Updated the build-from-repo instructions and removed the token input configuration for the server setup.
Comments suppressed due to low confidence (2)

README.md:414

  • Consider aligning the server naming keys across both configuration options. For instance, using a consistent key (e.g., 'github-mcp-server') in both the Docker and binary sections may improve clarity for users.
      "github-mcp-server": {

README.md:412

  • Since the previous token input configuration was removed, consider adding an inline comment to clarify that this change is intentional due to variable input limitations. This may prevent future confusion when users expect a token prompt.
    "inputs": [],

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

Copy link
Collaborator

@SamMorrowDrums SamMorrowDrums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope the input access is fixed soon 😅

@juruen juruen force-pushed the juruen/update-instructions branch from aa1d72d to 6dbe595 Compare March 27, 2025 08:53
@juruen juruen merged commit 09c9799 into main Mar 27, 2025
11 checks passed
@juruen juruen deleted the juruen/update-instructions branch March 27, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants