set user agent for client requests #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR sets a custom User-Agent for GitHub client requests in the github-mcp-server application.
- Adds a hard-coded User-Agent ("github-mcp-server/1.0") to override the default from the go-github library.
- Prepares groundwork for potential future refactoring to dynamically set the version.
Comments suppressed due to low confidence (1)
cmd/github-mcp-server/main.go:104
- [nitpick] Consider defining a constant for the User-Agent string to centralize the version value and simplify future updates.
ghClient.UserAgent = "github-mcp-server/1.0"
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
SamMorrowDrums
approved these changes
Apr 1, 2025
manian0430
pushed a commit
to ChrisLally/github-mcp-server
that referenced
this pull request
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set a User-Agent "github-mcp-server/1.0" for Client requests.
This overrides https://github.com/google/go-github/blob/0710d0b66118875dd853e35fdbeadf32f0264376/github/github.go#L36 and is set in https://github.com/google/go-github/blob/0710d0b66118875dd853e35fdbeadf32f0264376/github/github.go#L423
I wish there was a way to dynamically set the version, but I don't know of a sane way to pull the GitHub release version so starting with 1.0
With this being built directly in the command I don't have a good way to write a test in code, a future refactor could help with that.