Add missing milestone to create_issue
#88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a missing milestone parameter in the create_issue functionality to fix an issue with milestone handling. Key changes include:
- Adding "milestone" to the tool's input schema in tests.
- Updating the mock issue to include a milestone value.
- Incorporating an optional milestone parameter in the issue creation logic.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/github/issues_test.go | Adds assertions and test cases for milestone. |
| pkg/github/issues.go | Integrates optional milestone parameter into issue creation. |
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
pkg/github/issues.go
Outdated
| @@ -261,6 +261,9 @@ func createIssue(client *github.Client, t translations.TranslationHelperFunc) (t | |||
| }, | |||
| ), | |||
| ), | |||
| mcp.WithNumber("milestone", | |||
| mcp.Description("New milestone number"), | |||
There was a problem hiding this comment.
Is it new or can it be an existing milestone number that attaches the new issue to the existing milestone?
williammartin
force-pushed
the
wm/missing-milestone
branch
from
b5f7301 to
254be46
Compare
williammartin
force-pushed
the
wm/missing-milestone
branch
from
254be46 to
135754a
Compare
SamMorrowDrums
approved these changes
Apr 4, 2025
manian0430
pushed a commit
to ChrisLally/github-mcp-server
that referenced
this pull request
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #78