Skip to content

upgrade to new web component standards #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

keithamus
Copy link
Contributor

Much like github/auto-complete-element#104, github/auto-check-element#62, github/clipboard-copy-element#67, and github/image-crop-element#46 this PR upgrades us to the latest idioms we have within the Custom Elements landscape at GitHub. This means:

Development changes:

  • Update CI to use Node 18 LTS
  • Uses web-test-runner over karma.
  • Uses a slightly improved eslint config
  • Minor changes to TSconfig
  • Uses esbuild over rollup

User faces changes:

  • Emits JSX types, making it compatible with React
  • Reworks exports allowing for various patterns, including importing the web component without defining, or defining under different scopes or registries.
  • Outputs a custom elements manifest.

These changes make it easier for us to integrate into various systems, without causing breakages in older systems.

@keithamus keithamus requested a review from a team as a code owner June 16, 2023 09:01
@keithamus keithamus force-pushed the upgrade-to-new-web-component-standards branch from 9fc7fb8 to 874b7ce Compare June 16, 2023 09:02
@primer-css
Copy link

👋 Hello and thanks for pinging us! This issue or PR has been added to our inbox and a Design Infrastructure first responder will review it soon.

  • 🎨 If this is a PR that includes a visual change, please make sure to add screenshots in the description or deploy this code to a lab machine with instructions for how to test.
  • If this is a PR that includes changes to an interaction, please include a video recording in the description.
  • ⚠️ If this is urgent, please visit us in #primer on Slack and tag the first responders listed in the channel topic.

@keithamus keithamus merged commit a0df3be into main Jun 16, 2023
@keithamus keithamus deleted the upgrade-to-new-web-component-standards branch June 16, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants