-
Notifications
You must be signed in to change notification settings - Fork 5
chore(deps-dev): bump markdownlint from 0.36.1 to 0.37.3 #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
cce98aa
chore(deps-dev): bump markdownlint from 0.36.1 to 0.37.3
dependabot[bot] 62e3669
Progress converting from CommonJS -> ESM
JoyceZhu a18dbdf
progress
JoyceZhu 354ceaa
version update
JoyceZhu 84aebbc
progress?...
JoyceZhu 671c049
Fix missing trailing `.js` and following tests
JoyceZhu a03d501
Merge branch 'main' into dependabot/npm_and_yarn/markdownlint-0.37.3
JoyceZhu 239b15a
Fix `npm run test`
JoyceZhu db5cd52
Test fixes, begin to clean up
JoyceZhu d6d4f78
re-add space
JoyceZhu 3bd1c70
Update `README` with ESM examples
JoyceZhu 7c5aef4
remove outdated WIP comment
JoyceZhu 3a2ce49
Fix test
JoyceZhu d86cd37
Merge branch 'main' into dependabot/npm_and_yarn/markdownlint-0.37.3
JoyceZhu 3ae5b70
Update to version 0.2.0
JoyceZhu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
{ | ||
"root": true, | ||
"parserOptions": { | ||
"ecmaVersion": 2020 | ||
}, | ||
"env": { | ||
"es6": true, | ||
"node": true, | ||
"jest": true | ||
}, | ||
"plugins": ["github"], | ||
"extends": ["plugin:github/recommended"], | ||
"rules": { | ||
"import/no-commonjs": "off", | ||
"filenames/match-regex": "off", | ||
"i18n-text/no-en": "off" | ||
} | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
import { init } from "./index.js"; | ||
|
||
const options = init({ | ||
default: false, | ||
"heading-increment": true, | ||
"no-alt-text": true, | ||
"single-h1": true, | ||
"no-emphasis-as-heading": true, | ||
"first-line-heading": true, | ||
}); | ||
export const config = options; | ||
export const customRules = ["./index.js"]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
14 | ||
18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,20 @@ | ||
const _ = require("lodash"); | ||
import _ from "lodash-es"; | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. regular lodash is synchronous |
||
const accessibilityRules = require("./style/accessibility.json"); | ||
const base = require("./style/base.json"); | ||
const gitHubCustomRules = require("./src/rules/index").rules; | ||
|
||
module.exports = [...gitHubCustomRules]; | ||
import accessibilityRules from "./style/accessibility.json"; | ||
import base from "./style/base.json"; | ||
import { githubMarkdownLint } from "./src/rules/index.js"; | ||
|
||
const offByDefault = ["no-empty-alt-text"]; | ||
|
||
for (const rule of gitHubCustomRules) { | ||
for (const rule of githubMarkdownLint) { | ||
const ruleName = rule.names[1]; | ||
base[ruleName] = offByDefault.includes(ruleName) ? false : true; | ||
} | ||
|
||
module.exports.init = function init(consumerConfig) { | ||
export function init(consumerConfig) { | ||
// left overwrites right | ||
return _.defaultsDeep(consumerConfig, accessibilityRules, base); | ||
}; | ||
const foo = _.defaultsDeep(consumerConfig, accessibilityRules, base); | ||
return foo; | ||
} | ||
|
||
// export default githubMarkdownLint; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
{ | ||
"transform": { | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.