Latest version makes deleting local branches a pro feature

[b-johnse]

Description

Right click on a local branch > delete > asks to go pro instead of just deleting the branch.

This is not a pro feature, its a shortcut for a cli command

GitLens Version

15.4.0

VS Code Version

Version: 1.92.2 (user setup)
Commit: fee1edb8d6d72a0ddff41e5f71a671c23ed924b9
Date: 2024-08-14T17:29:30.058Z
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: 12.4.254.20-electron.0
OS: Windows_NT x64 10.0.22631

Git Version

No response

Logs, Screenshots, Screen Captures, etc

No response

[jkelroy]

Hello @b-johnse, I am not seeing the same behavior. Where are you deleting the branch from? Are you not logged in or are you logged in with a free account?

Can you please enable debug logging by running from GitLens: Enable Debug Logging from the Command Palette (F1 or ctrl/cmd+shift+p). This will enable logging to the GitLens and GitLens (Git) channel in the Output pane.

Once enabled, please reproduce the issue, and attach the log from the both GitLens and GitLens (Git) channels.

[eamodio]

@b-johnse are you trying to delete a branch that is on a worktree? If so, that could be why you are seeing this behavior, as worktrees are a Pro feature. Prior to the 15.4 release, GitLens wouldn't properly detect that the branch was on a worktree and let you think you could delete it, but then it would fail, because it is checked out on a worktree. Now in 15.4 we properly detect that can offer to delete the worktree first and then the branch, but since worktrees are Pro, you would see a that gated.

[eamodio]

I think we tracked down the case you might have been running into -- there was an issue where if you had VS Code open to a worktree, but tried to delete a local branch checked out on the "main" worktree we would incorrectly even allow that case (git won't let you delete the checked out branch on the main worktree) but it would also end up triggering our new worktree detection (which also shouldn't happen for the "main" worktree).

Can you please verify this fix in tomorrow's (v2024.09.05xx) pre-release edition of GitLens? Thank you so much!

You can switch to the pre-release edition of GitLens, by clicking on the "Switch to Pre-Release version of this extension" from the Extensions view.

[b-johnse]

@eamodio yes the pre-release version it works again! My use case was just deleting a local feature branch that had been PR'd into main
I don't do anything with worktrees and my settings have "gitlens.plusFeatures.enabled": false so sounds like you correctly found it

[nzaytsev]

@b-johnse - this is a quite strange case. The upgrade to pro prompt should not appear in case that you described. We would like to fully understand what has happened. Can we ask you to try reproduce it again (switch back to release version from the extension page) and make a few additional things for us to understand.

Currently, we'd like to see 2 things:

1. Could you record the video of the reproduced issue?
2. We need to be sure if you really don't use worktrees. Execute please the below command in your terminal in the project directory and put the result here with a comment

git worktree list

Could you also describe you steps to reproduce more detail please?