Windows support

[spderosso]

[Foucl]

is windows support off the table or just pushed further back on the roadmap? while pygit2 is - at least for anaconda users through the binary release of the mlabs channel - quite simple to install in a Python 3.5 environment, sh seems not to be compatible with Windows at all.

[techtonik]

It doesn't, because dependencies fail to install, and Visual Studio build dependency is too huge. This is a roadblock libgit2/pygit2#652 or https://mingwpy.github.io/ (for crosscompiler).

mingwpy in particular would be very useful project for the industry, but there is no entity that is interested to support the development.

[techtonik]

It will help if somebody could debug file descriptor leaks in pygit2 code - libgit2/pygit2#656

[techtonik]

Descriptor leaks are fixed, the next issue is libgit2/pygit2#657

[techtonik]

All tests are green. Next issue is to upload pygit2 wheels to PyPI libgit2/pygit2#662

[Foucl]

Thanks @techtonik for keeping track of that. maybe I missed something, but I had no problem getting pygit2 to work through the builds uploaded to the anaconda m-labs channel. As I mentioned in my original post, the problem was rather the sh module gitless makes heavy use of and which is not compatible with Windows.

[techtonik]

I can't confirm or deny that, because pip install pygit2 still doesn't work for my system. But in any case, the problem with sh is not actionable without specific issues.

[techtonik]

Yes, this is the message I've got now that pygit2 is available from PyPI in wheels:

>pip install gitless
Collecting gitless
  Downloading gitless-0.8.4.tar.gz
Collecting pygit2>=0.23.0 (from gitless)
  Downloading pygit2-0.24.2-cp27-cp27m-win32.whl (569kB)
    100% |################################| 573kB 396kB/s
Collecting sh>=1.11 (from gitless)
  Downloading sh-1.11.tar.gz
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "c:\users\user\appdata\local\temp2\pip-build-4m6kkg\sh\setup.py", line 4, in <module>
        import sh
      File "sh.py", line 37, in <module>
        support." % __version__)
    ImportError: sh 1.11 is currently only supported on linux and osx. please install pbs 0.110 (http://pypi.python.org/pypi/pbs) for windows support.

[spderosso]

Thank you all for looking into this. We can stop using sh if that's causing problems. The refactor shouldn't be too hard assuming we can still find a way to execute the git command.

Old versions of Gitless used to run inside git bash. How are you running Gitless in Windows?

[techtonik]

Well, I run gitless from cmd session, and use python -m gitless for now.

[Foucl]

this is the issue I was refering to in my first post here. I tried replacing all calls to sh with pbs equivalents (guided by http://stackoverflow.com/a/36004813):

from pbs import Command, ErrorReturnCode
git = Command('git')

This allows me to at least install gitless. It is also importable then in a python session. A call to the command line (e.g. gl init or gl status) results in an encoding related error, at least in cmd:

  File "C:\Users\DDMitarbeiter\Anaconda2\Scripts\gl-script.py", line 11, in <mod
ule>
    load_entry_point('gitless', 'console_scripts', 'gl')()
  File "c:\users\ddmitarbeiter\christopher\gitless\gitless\cli\gl.py", line 80,
in main
    pprint.err(e)
  File "c:\users\ddmitarbeiter\christopher\gitless\gitless\cli\pprint.py", line
80, in err
    puts(colored.red('Ô£ÿ {0}'.format(text)), stream=sys.stderr.write)
  File "c:\users\ddmitarbeiter\christopher\gitless\gitless\cli\pprint.py", line
40, in puts
    s = s.encode(ENCODING)
  File "C:\Users\DDMitarbeiter\Anaconda2\lib\site-packages\clint\textui\colored.
py", line 54, in func_help
    result = getattr(self.s, att)(*args, **kwargs)
  File "C:\Users\DDMitarbeiter\Anaconda2\lib\encodings\cp1252.py", line 12, in e
ncode
    return codecs.charmap_encode(input,errors,encoding_table)
UnicodeEncodeError: 'charmap' codec can't encode character u'\u2718' in position
 0: character maps to <undefined>

[spderosso]

@techtonik I think that running gl that way won't work until we replace all git calls with calls to the pygit2 library. You can't run git on the windows shell, right? My understanding is that you need to use git bash but I am not a windows user. If pygit2 is installing fine in Windows then maybe it's possible run Gitless from within git bash?

@Foucl The encoding error could be unrelated to windows. Are you running gl version 0.8.4? it fixed a few unicode related issues. Do you have the text encoding option in your shell set to "Unicode (UTF-8)"?

[techtonik]

@spderosso I can run git on the windows command line no problem. git on Windows comes with bash and wrapper that makes it possible. I am not sure that this bash works the same way as Linux, and the problem is in sh package for now, not in git.

>where git
C:\Program Files\Git\cmd\git.exe

[spderosso]

@techtonik good to know, it might work if we replace the calls to sh then (assuming the error @Foucl is getting is an encoding error unrelated to windows)