Skip to content

[db] Allow to update PaymentSourceInfos #7172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2021
Merged

[db] Allow to update PaymentSourceInfos #7172

merged 1 commit into from
Dec 14, 2021

Conversation

JanKoehnlein
Copy link
Contributor

Description

Workaround a TypeORM bug to allow updating DBPaymentSourceInfo entries when the resourceVersion doesn't change.

Related Issue(s)

Fixes #7171

How to test

Don't think manual testing is worth the effort. There is a unit test included. After merge we should be able to resend the failed event from Chargebee successfully.

Release Notes

NONE

@geropl
Copy link
Member

geropl commented Dec 14, 2021

/lgtm
/hold

The code looks good to me to fix the specific/rare case.

@JanKoehnlein This issue you mentioned looks very relevant. Did you try this? That would be good to know in general (although we don't have bigints in PK anywhere else I think). /holding in case you want to try it.

if you have the id as bigint db type, you need to set:

supportBigNumbers: true,
bigNumberStrings: false,

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 85fcd95bcc30a0bb3451ab050cee7394fb6c34b6

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geropl

Associated issue: #7171

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JanKoehnlein
Copy link
Contributor Author

/unhold

@geropl I think this is not worth risking a possibly breaking change. Already spent too much time on this given the expected frequency of this

@roboquat roboquat merged commit cd67ddf into main Dec 14, 2021
@roboquat roboquat deleted the jk/7171 branch December 14, 2021 10:13
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: webapp Meta team change is running in production deployed Change is completely running in production groundwork: in review release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chargebee] webhook failure when updating expired credit card
3 participants