Skip to content

version_info dies with git RC version #123

Closed
@sugi

Description

@sugi

git.cmd.Git.version_info gets ValueError when it's running with git RC release.

I think it may be OK to just skip non-integer values of version.

sugi@tempest:~% git --version
git version 1.8.4.rc3
sugi@tempest:~% python                                                        
Python 2.7.3 (default, Jan  2 2013, 13:56:14) 
[GCC 4.7.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import git
>>> g = git.Git()
>>> g.version()
'git version 1.8.4.rc3'
>>> g.version_info
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "git/cmd.py", line 261, in version_info
    return self._version_info
  File "git/cmd.py", line 237, in __getattr__
    return LazyMixin.__getattr__(self, name)
  File "git/util.py", line 357, in __getattr__
    self._set_cache_(attr)
  File "git/cmd.py", line 244, in _set_cache_
    self._version_info = tuple(int(n) for n in version_numbers.split('.')[:4])
  File "git/cmd.py", line 244, in <genexpr>
    self._version_info = tuple(int(n) for n in version_numbers.split('.')[:4])
ValueError: invalid literal for int() with base 10: 'rc3'

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions