Skip to content

commit trailers should be a list instead of a dictionary #1533

Closed
@nickbroon

Description

@nickbroon

Consider for example this linux kernel commit: https://gitlab.com/linux-kernel/stable/-/commit/1382999aa0548a171a272ca817f6c38e797c458c which has following trailers that include multiple cc and signed-off-by trailers:

Link: https://lore.kernel.org/lkml/[email protected]/


Cc: [email protected] # 6.1+
Reported-by: default avatarVlastimil Babka <[email protected]>
Suggested-by: default avatarLinus Torvalds <[email protected]>
Acked-by: default avatarLuigi Semenzato <[email protected]>
Cc: Peter Huewe <[email protected]>
Cc: Jarkko Sakkinen <[email protected]>
Cc: James Bottomley <[email protected]>
Cc: Johannes Altmanninger <[email protected]>
Signed-off-by: Jason Donenfeld's avatarJason A. Donenfeld <[email protected]>
Signed-off-by: default avatarLinus Torvalds <[email protected]>

And git interpret-trailers --parse ... will return all of these.

However the trailers() function returns a dictionary with only the last value for each token.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions