Specify explicit contents: read workflow permissions
#2033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three CI workflows that need only `contents: read` permissions and no other permissions did not have explicit permissions set, and would therefore be given default permissions configured for the repository, which might be more expansive than the workflows need. It is recommended to set explicit workflow permissions [1]. This does that, specifying permissions as `pythonpackage.yml` already did, and closing three `actions/missing-workflow-permissions` CodeQL alerts (new since gitpython-developers#2032 enabled scanning of GHA workflows). [1]: https://codeql.github.com/codeql-query-help/actions/actions-missing-workflow-permissions/
EliahKagan
force-pushed
the
gha-permissions
branch
from
d670878 to
a9833d6
Compare
EliahKagan
added a commit
to EliahKagan/gitdb
that referenced
this pull request
May 30, 2025
This change is analogous to gitpython-developers/GitPython#2033. See also gitpython-developers/smmap#60.
EliahKagan
added a commit
to EliahKagan/smmap
that referenced
this pull request
May 30, 2025
This change is analogous to gitpython-developers/GitPython#2033. See also gitpython-developers/gitdb#121.
This was referenced May 30, 2025
EliahKagan
added a commit
to EliahKagan/gitdb
that referenced
this pull request
May 30, 2025
This change is analogous to gitpython-developers/GitPython#2033. See also gitpython-developers/smmap#60.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify explicit
contents: readworkflow permissionsThree CI workflows that need only
contents: readpermissions and no other permissions did not have explicit permissions set, and would therefore be given default permissions configured for the repository, which might be more expansive than the workflows need.It is recommended to set explicit workflow permissions. This does that, specifying permissions as
pythonpackage.ymlalready did, and closing threeactions/missing-workflow-permissionsCodeQL alerts (new since #2032 enabled scanning of GHA workflows).I'll merge this once I verify that all CI checks still pass.