Skip to content

Configurable chunk size #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2018

Conversation

bpiotr
Copy link
Contributor

@bpiotr bpiotr commented Oct 3, 2017

Fixes #648

@Byron
Copy link
Member

Byron commented Oct 4, 2017

Thanks a lot! I am loving the tests, too!

I would happily merge it, it’s just flake8 having some silly white-space issue: https://travis-ci.org/gitpython-developers/GitPython/jobs/282786566#L1047 .

@alexandernst
Copy link

This is still not merged because of a single whitespace at the end of line 647. @bpiotr can you fix it or give me push permissions to your repo so I can push the fix there?

@codecov-io
Copy link

codecov-io commented May 16, 2018

Codecov Report

Merging #681 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #681      +/-   ##
==========================================
+ Coverage   94.67%   94.67%   +<.01%     
==========================================
  Files          59       59              
  Lines        9310     9322      +12     
==========================================
+ Hits         8814     8826      +12     
  Misses        496      496
Impacted Files Coverage Δ
git/test/test_repo.py 97.87% <100%> (+0.04%) ⬆️
git/cmd.py 83.62% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05e3b0e...d2c8074. Read the comment docs.

@bpiotr bpiotr force-pushed the configurable-chunk-size branch 2 times, most recently from beeb6e9 to 86eb7b5 Compare May 16, 2018 19:42
@bpiotr bpiotr force-pushed the configurable-chunk-size branch from 86eb7b5 to d2c8074 Compare May 16, 2018 19:52
@bpiotr
Copy link
Contributor Author

bpiotr commented May 16, 2018

@alexandernst OK, it's fixed now.

@alexandernst
Copy link

@Byron can we merge this and make a release?

@Byron Byron merged commit 7be3486 into gitpython-developers:master May 18, 2018
@Byron
Copy link
Member

Byron commented May 18, 2018

Thanks a ton for your contribution! There is another PR in review (#755), and when done, a new release can be cut.

@Byron Byron added this to the v2.1.10 - Bugfixes milestone May 18, 2018
@bpiotr bpiotr deleted the configurable-chunk-size branch May 18, 2018 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants