Skip to content

Update test_docs.py #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 15, 2018
Merged

Update test_docs.py #773

merged 2 commits into from
Jul 15, 2018

Conversation

markrowsoft
Copy link
Contributor

Using "import as" is normally a time saver but for usability of the documentation, please consider removing osp and join with fully qualified calls for better snippet readability.

I had some co-workers end up using popen commands vs using this library when I recommended GitPython as they did not understand how it worked from skimming the docs.

Sorry for not writing a test that fails... only a syntax change for readability.

markrowsoft and others added 2 commits June 14, 2018 15:32
Using "import as" is normally a time saver but for usability of the documentation, please consider removing osp and join with fully qualified calls for better snippet readability.
@codecov-io
Copy link

Codecov Report

Merging #773 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #773      +/-   ##
==========================================
- Coverage   94.69%   94.69%   -0.01%     
==========================================
  Files          59       59              
  Lines        9353     9352       -1     
==========================================
- Hits         8857     8856       -1     
  Misses        496      496
Impacted Files Coverage Δ
git/test/test_docs.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce5dfe7...4fa116c. Read the comment docs.

@Byron Byron merged commit 1ca25b9 into gitpython-developers:master Jul 15, 2018
@Byron
Copy link
Member

Byron commented Jul 15, 2018

Thanks a lot for your contribution! Along with that other PR which fixes the indentation, the tutorial should be so much easier to read and understand.

@Byron Byron added this to the v2.1.11 - Bugfixes milestone Jul 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants