Invisible text on solarized-dark terminal theme

[timabell]

Describe the bug
I fired up gitui on my default terminal configured with solarized light/dark colours on linux mint cinnamon, and was confused for a while (I'm new to gitui) because a load of the ui elements were missing. I now realise that's because the text & layout are the same colour as the background. I'm creating this issue not because I expect help, but more to document the issue and help future users who might run in to the same issue.

Expected behavior
Visible text / layout.

Screenshots

Dark theme - can't see half the ui:

Light theme, for comparison (everything shows fine)

Terminal dark theme config (manually installed solarized, wasn't available by default):

Context (please complete the following information):

tim@max:~/tmp/linked/lists(main)
$ cat /etc/issue
Linux Mint 20.2 Uma \n \l

tim@max:~/tmp/linked/lists(main)
$ gitui --version
gitui 0.21.0
tim@max:~/tmp/linked/lists(main)
$ which gitui 
/home/tim/bin/gitui
tim@max:~/tmp/linked/lists(main)
$ file ~/bin/gitui
/home/tim/bin/gitui: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=87f39159d2f1f2dabd76454f3882c933b51138f7, stripped
tim@max:~/tmp/linked/lists(main)
$ rustc --version
rustc 1.58.1 (db9d1b20b 2022-01-20)

Additional context

Issue #922 helped me figure out what was going on

I'm guessing this can be manually fixed with https://github.com/extrawurst/gitui/blob/master/THEMES.md and changing this ron file but I'm not sure without a bunch of experimenting what I'd need to change to what.

tim@max:~/tmp/linked/lists(main)
$ cat ~/.config/gitui/theme.ron
(
    selected_tab: Reset,
    command_fg: White,
    selection_bg: Blue,
    cmdbar_extra_lines_bg: Blue,
    disabled_fg: DarkGray,
    diff_line_add: Green,
    diff_line_delete: Red,
    diff_file_added: LightGreen,
    diff_file_removed: LightRed,
    diff_file_moved: LightMagenta,
    diff_file_modified: Yellow,
    commit_hash: Magenta,
    commit_time: LightCyan,
    commit_author: Green,
    danger_fg: Red,
    push_gauge_bg: Blue,
    push_gauge_fg: Reset,
)%

[timabell]

Managed to come up with this theme after a lot of trying out values to see what they do:

~/.config/gitui/theme.ron contents:

(
    // Colour map for solarized theme

    // Reset - background colour for theme (light/dark)
    // Black - black
    // White - white - invisible on light theme background
    // Red - red
    // Green - green
    // Yellow - orangey-yellow
    // Blue - blue
    // Magenta - pink/magenta
    // Cyan - cyan / light-blue
    // Gray - almost white - very low contrast on light theme background
    // DarkGray - almost black - invisible on dark theme background
    // LightRed - orangey-red
    // LightGreen - grey
    // LightYellow - grey
    // LightBlue - grey
    // LightMagenta - purple
    // LightCyan - slightly lighter grey

    // inactive tab+button text colour, plus inactive UI elements (borders etc)
    disabled_fg: LightGreen, // actually grey

    // active tab at top, text colour  - e.g. Status [1]
    selected_tab: Green,

    // - buttons at bottom - active button text - e.g. Branches [b]
    // - highlighted commit in log - text colour
    command_fg: Green,

    // buttons at bottom - background
    selection_bg: Reset, // turn off different background

    // don't know what this is for
    cmdbar_extra_lines_bg: LightCyan,

    diff_line_add: Green,
    diff_line_delete: Red,
    diff_file_added: Green,
    diff_file_removed: Red,
    diff_file_moved: Yellow,
    diff_file_modified: Blue,

    commit_hash: LightMagenta,
    commit_time: LightRed,
    commit_author: Yellow,

    danger_fg: Red,

    // Don't know what this is
    push_gauge_bg: Blue,
    push_gauge_fg: Black,
)

now available in my dotmatrix so it'll install on every machine for me

[extrawurst]

Nice thank you, maybe we can put them in the theme.md

[ludams]

Thanks for the solarized compatible gitui theme!

Instead of selection_bg: Reset, I use selection_bg: Gray, so I can still see, what's selected.
Posting it here, if someone else stumbles across this thread, who also uses solarized and likes to see the current selection.

[x86dev]

I have the same issue with my solarized theme ... so +1 here.

@timabell Thanks for the theme!

I improved it a little bit to also make it work with the latest version of gitui

(
    // Colour map for solarized theme

    // Reset - background colour for theme (light/dark)
    // Black - black
    // White - white - invisible on light theme background
    // Red - red
    // Green - green
    // Yellow - orangey-yellow
    // Blue - blue
    // Magenta - pink/magenta
    // Cyan - cyan / light-blue
    // Gray - almost white - very low contrast on light theme background
    // DarkGray - almost black - invisible on dark theme background
    // LightRed - orangey-red
    // LightGreen - grey
    // LightYellow - grey
    // LightBlue - grey
    // LightMagenta - purple
    // LightCyan - slightly lighter grey

    // inactive tab+button text colour, plus inactive UI elements (borders etc)
    disabled_fg: LightGreen, // actually grey

    // active tab at top, text colour  - e.g. Status [1]
    selected_tab: Green,

    // - buttons at bottom - active button text - e.g. Branches [b]
    // - highlighted commit in log - text colour
    command_fg: White,

    selection_fg: Gray,

    // buttons at bottom - background
    selection_bg: Reset, // turn off different background

    cmdbar_bg: Blue,

    // don't know what this is for
    cmdbar_extra_lines_bg: LightCyan,

    diff_line_add: Green,
    diff_line_delete: Red,
    diff_file_added: Green,
    diff_file_removed: Red,
    diff_file_moved: Yellow,
    diff_file_modified: Blue,

    commit_hash: LightMagenta,
    commit_time: LightRed,
    commit_author: Yellow,

    tag_fg: LightMagenta,
    branch_fg: LightYellow,

    danger_fg: Red,

    // Don't know what this is
    push_gauge_bg: Blue,
    push_gauge_fg: Black,
)