Skip to content

Invisible text on solarized-dark terminal theme #1360

Closed
@timabell

Description

@timabell

Describe the bug
I fired up gitui on my default terminal configured with solarized light/dark colours on linux mint cinnamon, and was confused for a while (I'm new to gitui) because a load of the ui elements were missing. I now realise that's because the text & layout are the same colour as the background. I'm creating this issue not because I expect help, but more to document the issue and help future users who might run in to the same issue.

Expected behavior
Visible text / layout.

Screenshots

Dark theme - can't see half the ui:
shutter_2022-09-27_02

Light theme, for comparison (everything shows fine)
shutter_2022-09-27_01

Terminal dark theme config (manually installed solarized, wasn't available by default):
shutter_2022-09-27_03

Context (please complete the following information):

tim@max:~/tmp/linked/lists(main)
$ cat /etc/issue
Linux Mint 20.2 Uma \n \l

tim@max:~/tmp/linked/lists(main)
$ gitui --version
gitui 0.21.0
tim@max:~/tmp/linked/lists(main)
$ which gitui 
/home/tim/bin/gitui
tim@max:~/tmp/linked/lists(main)
$ file ~/bin/gitui
/home/tim/bin/gitui: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), dynamically linked, BuildID[sha1]=87f39159d2f1f2dabd76454f3882c933b51138f7, stripped
tim@max:~/tmp/linked/lists(main)
$ rustc --version
rustc 1.58.1 (db9d1b20b 2022-01-20)

Additional context

Issue #922 helped me figure out what was going on

I'm guessing this can be manually fixed with https://github.com/extrawurst/gitui/blob/master/THEMES.md and changing this ron file but I'm not sure without a bunch of experimenting what I'd need to change to what.

tim@max:~/tmp/linked/lists(main)
$ cat ~/.config/gitui/theme.ron
(
    selected_tab: Reset,
    command_fg: White,
    selection_bg: Blue,
    cmdbar_extra_lines_bg: Blue,
    disabled_fg: DarkGray,
    diff_line_add: Green,
    diff_line_delete: Red,
    diff_file_added: LightGreen,
    diff_file_removed: LightRed,
    diff_file_moved: LightMagenta,
    diff_file_modified: Yellow,
    commit_hash: Magenta,
    commit_time: LightCyan,
    commit_author: Green,
    danger_fg: Red,
    push_gauge_bg: Blue,
    push_gauge_fg: Reset,
)%

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions