Skip to content
This repository was archived by the owner on Dec 2, 2017. It is now read-only.

added the ldap authentication. #144

Merged
merged 6 commits into from
Oct 17, 2017
Merged

added the ldap authentication. #144

merged 6 commits into from
Oct 17, 2017

Conversation

aoyawale
Copy link
Contributor

@aoyawale aoyawale commented Aug 10, 2017

No description provided.


## Freeipa

- In order to login to the Gogs using FreeIPA credentials, you need to create a bind account for Gogs to use:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gogs should be Gitea.

Copy link
Contributor Author

@aoyawale aoyawale Aug 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed the doc part to Gitea but, are the config files in this doc still point to gogs or should be changed to gitea too?

@lunny
Copy link
Member

lunny commented Aug 10, 2017

We also support OAuth(google+, github, twitter and about 20+ services) and OpenID login, if you can add them, that's be better. Of course, currently is also OK except some word Gogs should be replaced by Gitea.

@lafriks
Copy link
Member

lafriks commented Aug 10, 2017

Please also add LDAP sample for Microsoft AD:

Port: 389
User search base: (&(objectCategory=Person)(memberOf=CN=user-group,OU=example,DC=example,DC=org)(sAMAccountName=%s)(!(UserAccountControl:1.2.840.113556.1.4.803:=2)))
Admin filter: (memberOf=CN=admin-group,OU=example,DC=example,DC=org)
Username: sAMAccountName

- This authentication is activate
- Enable or disable this auth.

## Microsoft AD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking that these need to be added under LDAP section as additional example lines for appropriate fields

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops sorry for that. Let me change it.

@aoyawale
Copy link
Contributor Author

I can update for the other authentication we support but, I don't have docs for those.

@lunny
Copy link
Member

lunny commented Aug 11, 2017

@jlozadad OK. that should be another PR.

@lunny
Copy link
Member

lunny commented Aug 11, 2017

LGTM

@strk
Copy link
Member

strk commented Aug 11, 2017

There are references to "Gogs" still, in its current version, can you update them ?
Also, it would be great to describe what Verify group membership in LDAP does, exactly.

@aoyawale
Copy link
Contributor Author

aoyawale commented Aug 11, 2017

looks like my previous comment got buried with the commit. But, yes I was asking the same thing. Some config still shows "gogs" and I was wondering if that part changed in gitea too or still the same. If all of it changed to gitea then plz confirm and I'll change it again.

@lafriks
Copy link
Member

lafriks commented Aug 19, 2017

@jlozadad I was thinking that these examples needs to be added not in separate section but at the end of each description as additional example.
For example:

- User Search Base **(required)**
  - The LDAP base at which user accounts will be searched for.
  - Example: `ou=Users,dc=mydomain,dc=com`
  - Example for Microsoft AD: `(&(objectCategory=Person)(memberOf=CN=user-group,OU=example,DC=example,DC=org)(sAMAccountName=%s)(!(UserAccountControl:1.2.840.113556.1.4.803:=2)))`

etc

@aoyawale
Copy link
Contributor Author

so basically copy the example you mentioned and add it to the others? I'm not sure what would look different for the others.

@lafriks
Copy link
Member

lafriks commented Aug 24, 2017

@jlozadad yes add examples for Microsoft AD to sections port, user search base, admin filter and username

@aoyawale
Copy link
Contributor Author

I added the changes. Let me know if its correct.

@lafriks
Copy link
Member

lafriks commented Aug 24, 2017

Not really, I did mean only parts that are meant for each section like I did give example in comment 5 days ago

@appleboy
Copy link
Member

any updates on this?

@lafriks
Copy link
Member

lafriks commented Oct 16, 2017

Fixed

@daviian
Copy link
Member

daviian commented Oct 17, 2017

LGTM

@lafriks lafriks merged commit ca89625 into go-gitea:master Oct 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants