Skip to content

Commit 34688e1

Browse files
sunboyysapktechknowlogicklafrikszeripath
committed
Update CONTRIBUTING.md to include building JS (#9454)
* Update CONTRIBUTING.md to include building JS Signed-off-by: sunboyy <[email protected]> * Edit minimum Node.js version in CONTRIBUTING.md Signed-off-by: sunboyy <[email protected]> Co-authored-by: Antoine GIRARD <[email protected]> Co-authored-by: techknowlogick <[email protected]> Co-authored-by: Lauris BH <[email protected]> Co-authored-by: zeripath <[email protected]>
1 parent e394504 commit 34688e1

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

CONTRIBUTING.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -114,10 +114,10 @@ included in the next released version.
114114
## Building Gitea
115115

116116
Generally, the go build tools are installed as-needed in the `Makefile`.
117-
An exception are the tools to build the CSS and images.
117+
An exception are the tools to build the CSS, JS and images.
118118

119-
- To build CSS: Install [Node.js](https://nodejs.org/en/download/package-manager) at version 8.0 or above
120-
with `npm` and then run `npm install` and `make css`.
119+
- To build CSS and JS: Install [Node.js](https://nodejs.org/en/download/package-manager) at version 10.0 or above
120+
with `npm` and then run `npm install`, `make css` and `make js`.
121121
- To build Images: ImageMagick, inkscape and zopflipng binaries must be
122122
available in your `PATH` to run `make generate-images`.
123123

@@ -166,7 +166,7 @@ import (
166166

167167
To maintain understandable code and avoid circular dependencies it is important to have a good structure of the code. The gitea code is divided into the following parts:
168168

169-
- **integration:** Integrations tests
169+
- **integration:** Integrations tests
170170
- **models:** Contains the data structures used by xorm to construct database tables. It also contains supporting functions to query and update the database. Dependecies to other code in Gitea should be avoided although some modules might be needed (for example for logging).
171171
- **models/fixtures:** Sample model data used in integration tests.
172172
- **models/migrations:** Handling of database migrations between versions. PRs that changes a database structure shall also have a migration step.

0 commit comments

Comments
 (0)