Skip to content

Update CONTRIBUTING.md to include building JS #9454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 24, 2019

Conversation

sunboyy
Copy link
Contributor

@sunboyy sunboyy commented Dec 21, 2019

This pull request updates CONTRIBUTING.md in the Building Gitea section. I added information about building JavaScript files so that new contributors can setup the project more easily.

@sunboyy sunboyy force-pushed the contributing-build-js branch from ae8b6f8 to ce94e6b Compare December 21, 2019 09:26
@codecov-io
Copy link

codecov-io commented Dec 21, 2019

Codecov Report

Merging #9454 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9454      +/-   ##
==========================================
- Coverage   41.51%   41.51%   -0.01%     
==========================================
  Files         571      571              
  Lines       74648    74648              
==========================================
- Hits        30993    30988       -5     
- Misses      39815    39820       +5     
  Partials     3840     3840
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️
routers/repo/view.go 38.59% <0%> (-0.88%) ⬇️
models/gpg_key.go 55.03% <0%> (-0.56%) ⬇️
models/repo_list.go 74.07% <0%> (+0.92%) ⬆️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e394504...8489269. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 21, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 21, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 21, 2019
Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is out-of-date make build will generate the css and js now.

@lunny
Copy link
Member

lunny commented Dec 21, 2019

You can still use make generate build but generate could be ignored.

@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label Dec 22, 2019
@techknowlogick techknowlogick dismissed their stale review December 23, 2019 05:41

dismissing my review

@6543
Copy link
Member

6543 commented Dec 23, 2019

ping lgtm

@techknowlogick techknowlogick merged commit 34688e1 into go-gitea:master Dec 24, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.