Skip to content

Commit 9798014

Browse files
authored
Show original author's reviews on pull summary box (#13127)
follow #12039, show original author's reviews by other way. fix #11705. Signed-off-by: a1012112796 <[email protected]>
1 parent e70df67 commit 9798014

File tree

4 files changed

+53
-2
lines changed

4 files changed

+53
-2
lines changed

models/review.go

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -486,6 +486,20 @@ func GetReviewersByIssueID(issueID int64) ([]*Review, error) {
486486
return reviews, nil
487487
}
488488

489+
// GetReviewersFromOriginalAuthorsByIssueID gets the latest review of each original authors for a pull request
490+
func GetReviewersFromOriginalAuthorsByIssueID(issueID int64) ([]*Review, error) {
491+
reviews := make([]*Review, 0, 10)
492+
493+
// Get latest review of each reviwer, sorted in order they were made
494+
if err := x.SQL("SELECT * FROM review WHERE id IN (SELECT max(id) as id FROM review WHERE issue_id = ? AND reviewer_team_id = 0 AND type in (?, ?, ?) AND original_author_id <> 0 GROUP BY issue_id, original_author_id) ORDER BY review.updated_unix ASC",
495+
issueID, ReviewTypeApprove, ReviewTypeReject, ReviewTypeRequest).
496+
Find(&reviews); err != nil {
497+
return nil, err
498+
}
499+
500+
return reviews, nil
501+
}
502+
489503
// GetReviewByIssueIDAndUserID get the latest review of reviewer for a pull request
490504
func GetReviewByIssueIDAndUserID(issueID, userID int64) (*Review, error) {
491505
return getReviewByIssueIDAndUserID(x, issueID, userID)

routers/repo/issue.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -450,6 +450,13 @@ type repoReviewerSelection struct {
450450
func RetrieveRepoReviewers(ctx *context.Context, repo *models.Repository, issue *models.Issue, canChooseReviewer bool) {
451451
ctx.Data["CanChooseReviewer"] = canChooseReviewer
452452

453+
originalAuthorReviews, err := models.GetReviewersFromOriginalAuthorsByIssueID(issue.ID)
454+
if err != nil {
455+
ctx.ServerError("GetReviewersFromOriginalAuthorsByIssueID", err)
456+
return
457+
}
458+
ctx.Data["OriginalReviews"] = originalAuthorReviews
459+
453460
reviews, err := models.GetReviewersByIssueID(issue.ID)
454461
if err != nil {
455462
ctx.ServerError("GetReviewersByIssueID", err)

templates/repo/issue/view_content/pull.tmpl

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{{if .PullReviewers }}
1+
{{if or .PullReviewers .OriginalReviews }}
22
<div class="comment box">
33
<div class="content">
44
<div class="ui segment">
@@ -54,6 +54,24 @@
5454
</div>
5555
</div>
5656
{{end}}
57+
{{range .OriginalReviews}}
58+
{{ $createdStr:= TimeSinceUnix .UpdatedUnix $.Lang }}
59+
<div class="ui divider"></div>
60+
<div class="review-item">
61+
<div class="review-item-left">
62+
<a href="{{$.Repository.OriginalURL}}" class="ui poping up" data-content="{{$.i18n.Tr "repo.migrated_from_fake" $.Repository.GetOriginalURLHostname | Safe }}"><span class="text black "><i class="fa {{MigrationIcon $.Repository.GetOriginalURLHostname}}" aria-hidden="true"></i> {{ .OriginalAuthor }}</span></a>
63+
</div>
64+
<div class="review-item-right">
65+
<span class="type-icon text {{if eq .Type 1}}green
66+
{{- else if eq .Type 2}}grey
67+
{{- else if eq .Type 3}}red
68+
{{- else if eq .Type 4}}yellow
69+
{{else}}grey{{end}}">
70+
{{svg (printf "octicon-%s" .Type.Icon)}}
71+
</span>
72+
</div>
73+
</div>
74+
{{end}}
5775
</div>
5876
</div>
5977
</div>

templates/repo/issue/view_content/sidebar.tmpl

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
</div>
5050

5151
<div class="ui assignees list">
52-
<span class="no-select item {{if .PullReviewers}}hide{{end}}">{{.i18n.Tr "repo.issues.new.no_reviewers"}}</span>
52+
<span class="no-select item {{if or .OriginalReviews .PullReviewers}}hide{{end}}">{{.i18n.Tr "repo.issues.new.no_reviewers"}}</span>
5353
<div class="selected">
5454
{{range .PullReviewers}}
5555
<div class="item" style="margin-bottom: 10px;">
@@ -73,6 +73,18 @@
7373
</span>
7474
</div>
7575
{{end}}
76+
{{range .OriginalReviews}}
77+
<div class="item" style="margin-bottom: 10px;">
78+
<a href="{{$.Repository.OriginalURL}}" class="ui poping up" data-content="{{$.i18n.Tr "repo.migrated_from_fake" $.Repository.GetOriginalURLHostname | Safe }}"><span class="text black "><i class="fa {{MigrationIcon $.Repository.GetOriginalURLHostname}}" aria-hidden="true"></i> {{ .OriginalAuthor }}</span></a>
79+
<span class="ui right type-icon text {{if eq .Type 1}}green
80+
{{- else if eq .Type 2}}grey
81+
{{- else if eq .Type 3}}red
82+
{{- else if eq .Type 4}}yellow
83+
{{- else}}grey{{end}} right ">
84+
{{svg (printf "octicon-%s" .Type.Icon)}}
85+
</span>
86+
</div>
87+
{{end}}
7688
</div>
7789
</div>
7890
<div class="ui divider"></div>

0 commit comments

Comments
 (0)