When using templates, submodules do not get "inherited"

[HanEmile]

• Gitea version (or commit ref): 1.11.1
• Git version: 2.23.1
• Operating system: NixOS
• Database: shouldn't matter, if so, please write
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (POC can be found here)
  • No
  • Not relevant

Description

So I tried out the new template feature and found out, that when using templates, submodules do not get "inherited".

Reproduction

1. Create a repo A that should be used as a template
2. Mark the repo A as a template in the repos settings
3. Create a repo B using the repo A as a submodule: git submodule add <repo A>
4. Create a repo C using B as a template. My result is that C does not contains the submodule A.

[davidsvantesson]

Seems it has to be restored from .gitmodules. For example like this:
https://gist.github.com/aroemen/5027030

[stale]

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

[davidsvantesson]

I think this is something that can be fixed. GitHub doesn't handle it so should maybe be an option.

[davidsvantesson]

Something to notice is that the ".gitmodules" file does not contain information about which commit is currently checked out, only the repo path and url. So if re-initalizing submodules from the ".gitmodules" file, every submodule will be added with "HEAD" checked out in the parent repo.
This is probably not what you want. If the new repo should look same as the latest commit of the template repo, you need to checkout each submodule repo to the same commit.

So somthing like this would be needed:

• Run git submodule status in the template repo to get all submodules (paths) and their checked out commit.
• Clone template repo without submodules and remove .git folder (as today)
  Then for each submodule:
• To get submodule url run: git config -f .gitmodules --get "submodule.<submodule path>.url"
• Remove submodule folder: rmdir <submodule path>
• Run git submodule add <submodule url> <submodule path>
• Got to submodule: cd <submodule path>
• and change checked out commit: git checkout <submodule commit>
• All submodules with correct commit will be added when running git add --all

[lunny]

related with #9126

[stale]

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

[stale]

This issue has been automatically closed because of inactivity. You can re-open it if needed.

[6543]

status?