When there is no branch protected, the reviews of those who have code write permission should be consider as official

[lunny]

As above.

If no branch protected, then no official review. Should we change that?

[guillep2k]

I thought it was always official unless there's a whitelist and the user is not in it. Maybe we've missed that case for unprotected branches?

[lunny]

@guillep2k see https://github.com/go-gitea/gitea/blob/master/models/review.go#L195 , when there is no branch protected, no reviewer will be consider as official.

[guillep2k]

As Syndrome said: "if everyone is special, then nobody is special" 😄

I agree, I think those should be "official".

[stale]

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.