Commits and pull files

[lunny]

Before we can start a review, we can implement comment on one line of PRs at first.
I think this includes two sub issues.

• Commit comment Pull request review/approval and comment on code #3748 see Add inline comments on commits #4898
• Pull files comment Pull request review/approval and comment on code #3748

[bkcsoft]

well, If we implement comments on commits we should get this "for free" 🙂

[metalmatze]

I'm not sure. I don't know the internals, but the comment may go onto a commit page. Then you can discuss this commit.
But this issue targets a bigger picture. A PR might have multiple commits and those can change over time. So I agree that comments on commits might benefit comments on PR with some work already done nevertheless I feel that there's more to it.

[lunny]

Yes, comment on commits.

[bkcsoft]

I can probably make a proof of concept for this sometime during the weekend or next week

[lunny]

@bkcsoft any update?

[strk]

Aren't we going to do this with git-appraise ? See #733

[sokolovstas]

I can look at this, but this will be not so fast

[lunny]

Move this v1.2 since #733 has moved.