GIT sha256 support

[6543]

SHA256 support comes in git-2.29, test deployment on codeberg-test does not work. Steps to reproduce:

git init --object-format=sha256
touch test
git add test
git commit -m "test"
git remote add origin git@codeberg.org:reinerh/test.git
git push -u origin main

Error: fatal: Protokollfehler: unerwartetes capabilities^{}

gitea version: 1.14.0+dev-294-g594cc4aa2

[a1012112796]

Not suggest add it now because it still an experimental feature in git.
The error message is because git sha256 need core > repositoryformatversion=1 and extensions > objectformat = sha256.

[Gusted]

How do we propose to set the SHA-256 setting for a repo? I assume we don't want to set this global(as this would only make sense for "new" gitea instance). Would it be a simple option on the repo creation to enable the SHA256 format?

[lunny]

If the repository is initialized in Gitea, we can have option in creating repository page, but if it's a repository pushing to create, we should have another method to detect it.

[deknos]

Hello,
NIST wanna sunset SHA1: https://www.nist.gov/news-events/news/2022/12/nist-retires-sha-1-cryptographic-algorithm

Yes, this will take some time and it is until 2030. Still, people should start it, as there are still no migration possibilities like i don't know, git make-readonly ; git migrate start --to=SHA2-256 ; git migrate clean --away=SHA1 or whatever. Also, this is also only for local git, there's no possibility for this for fetching/pulling already cloned gits.

Also, there may be more hashing algorithms in the future, or some are broken, just migrating to one will perhaps be enough for 10 years, but then we may have this issue again. Please for now, at least test and provide sha256 as an option.

migrating data will take time.

[Sword-Smith]

Hello, NIST wanna sunset SHA1: https://www.nist.gov/news-events/news/2022/12/nist-retires-sha-1-cryptographic-algorithm

Yes, this will take some time and it is until 2030. Still, people should start it, as there are still no migration possibilities like i don't know, git make-readonly ; git migrate start --to=SHA2-256 ; git migrate clean --away=SHA1 or whatever. Also, this is also only for local git, there's no possibility for this for fetching/pulling already cloned gits.

Also, there may be more hashing algorithms in the future, or some are broken, just migrating to one will perhaps be enough for 10 years, but then we may have this issue again. Please for now, at least test and provide sha256 as an option.

migrating data will take time.

I second this. Also even if SHA-1 wasn't broken, it would still only be secure up to 80 bits, which shouldn't be considered safe nowadays. You should aim for 100 bits or preferably 128 bits which SHA-256 will give you.

Not as critical as I thought since the SHA-1 function is being used in a way that guarantees that the length is not affected, so the known SHA-1 attacks would not work. Also: A collision is not that dangerous, you need a second-preimage attack which AFAIK still has 160 bits security the way that SHA-1 is currently being used in git.