Skip to content

Arbitrary PR id in PR URL always leads to first PR in repository #16405

Closed
@flozzone

Description

@flozzone
  • Gitea version (or commit ref): 1.14.4
  • Git version:
  • Operating system: Docker container
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
  • Log gist:

Description

For a PR URL with a unparseable PR id like https://try.gitea.io/our-org/custom-project/pulls/[WRONGSYNTAX] the resulting PR is always the first PR in the project, instead of showing a 404 page. Constructing URLs like this can result in wrong URLs and should therefore also result in a 404 page.

...

Screenshots

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions