Skip to content

Pull request with long commit message in title fails to open #16507

New issue
New issue
Closed
#16517
Closed
Pull request with long commit message in title fails to open#16507
#16517
@amber-ailuridae

Description

@amber-ailuridae
amber-ailuridae
opened on Jul 21, 2021
  • Gitea version (or commit ref): try.gitea.io version (1.16.0+dev-28-g28f6f7bb0)
  • Git version: 2.30.0.windows.2
  • Operating system: Microsoft Windows 10 Pro, Version 10.0.19042 Build 19042
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
  • Log gist:
    Browser logs enumerated below. 
    duh:1 Tracking Prevention blocked access to storage for https://secure.gravatar.com/avatar/e64fbf2d101290423cd7c42d02c378b0?d=identicon&s=96.
duh:1 Tracking Prevention blocked access to storage for https://secure.gravatar.com/avatar/e64fbf2d101290423cd7c42d02c378b0?d=identicon&s=112.
index.js?v=37edd3a08b9e064018380614f83a1b4b:62 jQuery.Deferred exception: SimpleMDE is not defined ReferenceError: SimpleMDE is not defined
  at Ba (https://try.gitea.io/assets/js/index.js?v=37edd3a08b9e064018380614f83a1b4b:60:1714)
  at Xm (https://try.gitea.io/assets/js/index.js?v=37edd3a08b9e064018380614f83a1b4b:29:33228)
  at https://try.gitea.io/assets/js/index.js?v=37edd3a08b9e064018380614f83a1b4b:62:20111
  at Generator.next (<anonymous>)
  at u (https://try.gitea.io/assets/js/index.js?v=37edd3a08b9e064018380614f83a1b4b:29:26053) undefined
o.Deferred.exceptionHook @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
Pi @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
(anonymous) @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
Promise.then (async)
Lt @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
Pi @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
setTimeout (async)
(anonymous) @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
je @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
fireWith @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
fire @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
je @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
fireWith @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
ready @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
We @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
index.js?v=37edd3a08b9e064018380614f83a1b4b:60 Uncaught ReferenceError: SimpleMDE is not defined
  at Ba (index.js?v=37edd3a08b9e064018380614f83a1b4b:60)
  at Xm (index.js?v=37edd3a08b9e064018380614f83a1b4b:29)
  at index.js?v=37edd3a08b9e064018380614f83a1b4b:62
  at Generator.next (<anonymous>)
  at u (index.js?v=37edd3a08b9e064018380614f83a1b4b:29)
Ba @ index.js?v=37edd3a08b9e064018380614f83a1b4b:60
Xm @ index.js?v=37edd3a08b9e064018380614f83a1b4b:29
(anonymous) @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
u @ index.js?v=37edd3a08b9e064018380614f83a1b4b:29
setTimeout (async)
o.readyException @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
(anonymous) @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
Lt @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
Pi @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
setTimeout (async)
(anonymous) @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
je @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
fireWith @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
fire @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
je @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
fireWith @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
Pi @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
(anonymous) @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
Promise.then (async)
Lt @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
Pi @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
setTimeout (async)
(anonymous) @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
je @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
fireWith @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
fire @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
je @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
fireWith @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
ready @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62
We @ index.js?v=37edd3a08b9e064018380614f83a1b4b:62

Description

If you create a pull request from a commit with a very long commit message (>255 characters) and try to open a pull request without trimming down the title, opening the pull request will fail without any error notification. Typically, if you try to create a commit message longer than 100 characters in the UI, it will tell you to shorten the message. Furthermore, if you try to create a pull request with too long of a title, the input box will prevent you from typing more characters. However, this can be circumvented. This issue can be reproduced by:

  1. Creating a commit with a very long message (>255 characters) on your local machine.
  2. Pushing the commit to Gitea.
  3. Creating a pull request with only that commit.
  4. Selecting Create Pull Request on the New Pull Request page without editing the title.

I was able to replicate this issue on try.gitea.io, but I also can replicate it on my private Gitea instance running 1.13.2 with PostgreSQL. This issue arose when a developer on my team said that they could not open a pull request. We sat down and troubleshooted the issue, narrowing it down to this problem.

The only fix this really needs is some kind of error message that notifies the user that they need to trim down their PR title.

Screenshots

2021-07-21_9-29-15.mp4

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions