500 error on organization page: error calling DescriptionHTML

[aanderse]

Gitea Version

1.15.3

Operating System

Linux (NixOS)

Browser Version

Firefox 92.0

Can you reproduce the bug on the Gitea demo site?

No

Description

A user on my gitea instance reported that whenever they hit the "org" page for one organization they get a 500 error. I'm able to reproduce this. The error only occurs on 1 organization - all other organizations are viewable without any errors.

I imagine a select statement in one of the tables in the associated database could provide more relevant information, but I'm not sure which table(s) to select from.

Any help would be greatly appreciated.

Thank you.

Screenshots

[wxiaoguang]

I think the problem may be caused by a special description of the repo. Can you share your repo description? Repo Settings -> Basic Settings -> Description, or just search the descrption column in database table repository.

[techknowlogick]

Which database are you using?

[aanderse]

I think the problem may be caused by a special description of the repo. Can you share your repo description? Repo Settings -> Basic Settings -> Description, or just search the descrption column in database table repository.

MariaDB [gitea]> select id, owner_id, lower_name, name, description, website from repository where owner_id = 3;
+----+----------+-----------------------------------+-----------------------------------+-------------------------------------------------------------------+---------+
| id | owner_id | lower_name                        | name                              | description                                                       | website |
+----+----------+-----------------------------------+-----------------------------------+-------------------------------------------------------------------+---------+
|  1 |        3 | skrit                             | Skrit                             |                                                                   |         |
|  4 |        3 | sno                               | SNO                               | dungeon siege mesh file format for terrain                        |         |
|  7 |        3 | editor                            | Editor                            |                                                                   |         |
| 15 |        3 | tank                              | Tank                              | dungeon siege archive format                                      |         |
| 17 |        3 | ui                                | UI                                | dungeon siege ui                                                  |         |
| 26 |        3 | reverse-engineering-dungeon-siege | reverse-engineering-dungeon-siege | A reverse engineering repository originally forked from glampert. |         |
| 27 |        3 | opensiege                         | OpenSiege                         |                                                                   |         |
| 31 |        3 | docs                              | Docs                              | A documentation repository                                        |         |
| 35 |        3 | flm                               | FLM                               | FLM converter                                                     |         |
| 37 |        3 | vsg-siege                         | vsg-siege                         | Converting Open Siege to use VulkanSceneGraph                     |         |
+----+----------+-----------------------------------+-----------------------------------+-------------------------------------------------------------------+---------+
10 rows in set (0.001 sec)

Which database are you using?

~> mariadb --version                                                                                                                                 
mariadb  Ver 15.1 Distrib 10.5.10-MariaDB, for Linux (x86_64) using readline 5.1

I don't see any obvious problems in the description fields.

[zeripath]

Do you have a external trackers?

Could you apply the following patch:

diff --git a/modules/markup/html.go b/modules/markup/html.go
index d6a2571e2..0dd24ced3 100644
--- a/modules/markup/html.go
+++ b/modules/markup/html.go
@@ -6,6 +6,7 @@ package markup
 
 import (
 	"bytes"
+	"fmt"
 	"io"
 	"io/ioutil"
 	"net/url"
@@ -252,9 +253,18 @@ func RenderIssueTitle(
 	}, title)
 }
 
-func renderProcessString(ctx *RenderContext, procs []processor, content string) (string, error) {
+func renderProcessString(ctx *RenderContext, procs []processor, content string) (processed string, err error) {
 	var buf strings.Builder
-	if err := postProcess(ctx, procs, strings.NewReader(content), &buf); err != nil {
+
+	defer func() {
+		if panicked := recover(); panicked != nil {
+			stack := string(log.Stack(2))
+			log.Error("PANIC: %v whilst rendering %q\n%s", panicked, content, stack)
+			err = fmt.Errorf("PANIC: %v whilst rendering %q", panicked, content)
+		}
+	}()
+
+	if err = postProcess(ctx, procs, strings.NewReader(content), &buf); err != nil {
 		return "", err
 	}
 	return buf.String(), nil

This would give us a bit more information and prevent the 500 at the same time.

[aanderse]

@zeripath thanks for the patch... unfortunately the crash still happens and the logs are the same. I started trying some other links and it appears that several of the repositories under this organization simply crash when I surf to them, for example when I hit the sno repository under this organization I get a "Internal Server Error" with the following in my syslog:

Oct 13 20:15:54 siegetheday gitea[388734]: 2021/10/13 20:15:54 ...s/repo_permission.go:154:func1() [T] Permission Loaded for 1:aaron in 4:DungeonSiege/SNO:
Oct 13 20:15:54 siegetheday gitea[388734]:         Permissions: AccessMode: 0:none, 0 Units, 0 UnitsMode(s): [  ]
Oct 13 20:15:54 siegetheday gitea[388734]: 2021/10/13 20:15:54 routers/web/base.go:131:1() [E] PANIC: runtime error: index out of range [0] with length 0
Oct 13 20:15:54 siegetheday gitea[388734]:         runtime/panic.go:88 (0x43fea4)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/models/login_source.go:92 (0x1384b3b)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/models/repo_unit.go:31 (0x13f59d9)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/xorm.io/xorm/session.go:544 (0xc2ed0a)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/xorm.io/xorm/session.go:695 (0xc2f724)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/xorm.io/xorm/session.go:409 (0xc2bc99)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/xorm.io/xorm/session_find.go:240 (0xc35d4a)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/xorm.io/xorm/session_find.go:160 (0xc34c50)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/xorm.io/xorm/session_find.go:31 (0xc34244)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/models/repo_unit.go:210 (0x13f6964)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/models/repo.go:348 (0x13c4b73)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/models/repo_permission.go:186 (0x13ed2b0)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/models/repo_permission.go:142 (0x156f852)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/modules/context/repo.go:341 (0x156f7db)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/modules/context/repo.go:455 (0x157045d)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/modules/web/route.go:55 (0x1e966bb)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/go-chi/chi/mux.go:436 (0x155b4aa)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/modules/web/route.go:103 (0x1e96af6)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/modules/web/route.go:103 (0x1e96af6)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/modules/web/route.go:103 (0x1e96af6)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/go-chi/chi/middleware/get_head.go:37 (0x1eb9d81)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/modules/web/route.go:103 (0x1e96af6)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/modules/context/context.go:776 (0x157c1a9)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/go-chi/chi/mux.go:70 (0x155900a)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/go-chi/chi/mux.go:311 (0x155f3fb)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/go-chi/chi/mux.go:436 (0x155b4aa)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/routers/web/base.go:186 (0x20ce5d0)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/gitea.com/go-chi/session/session.go:256 (0x148dd6e)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/modules/public/public.go:42 (0x20a712e)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/go-chi/chi/mux.go:70 (0x155900a)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/go-chi/chi/mux.go:311 (0x155f3fb)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/go-chi/chi/mux.go:436 (0x155b4aa)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/routers/common/middleware.go:72 (0x1ebf5fd)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/routers/common/logger.go:23 (0x1ebe83b)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/go-chi/chi/middleware/strip.go:30 (0x1eba687)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/chi-middleware/proxy/middleware.go:37 (0x1eb5cee)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/routers/common/middleware.go:25 (0x1ebf13c)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/go-chi/chi/mux.go:87 (0x1558d90)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/modules/web/route.go:318 (0x1e95953)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/gorilla/context/context.go:141 (0x1212953)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2867 (0x7c72c2)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:1932 (0x7c27ec)
Oct 13 20:15:54 siegetheday gitea[388734]:         runtime/asm_amd64.s:1371 (0x47d320)
Oct 13 20:15:54 siegetheday gitea[388734]:         
Oct 13 20:15:54 siegetheday gitea[388734]: 2021/10/13 20:15:54 ...common/middleware.go:64:1() [E] PANIC: interface conversion: interface {} is nil, not *context.APIContext
Oct 13 20:15:54 siegetheday gitea[388734]:         runtime/iface.go:261 (0x415e0e)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/modules/context/api.go:135 (0x20ce51e)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/routers/web/base.go:151 (0x20cdba0)
Oct 13 20:15:54 siegetheday gitea[388734]:         runtime/panic.go:965 (0x442958)
Oct 13 20:15:54 siegetheday gitea[388734]:         runtime/panic.go:88 (0x43fea4)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/models/login_source.go:92 (0x1384b3b)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/models/repo_unit.go:31 (0x13f59d9)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/xorm.io/xorm/session.go:544 (0xc2ed0a)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/xorm.io/xorm/session.go:695 (0xc2f724)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/xorm.io/xorm/session.go:409 (0xc2bc99)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/xorm.io/xorm/session_find.go:240 (0xc35d4a)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/xorm.io/xorm/session_find.go:160 (0xc34c50)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/xorm.io/xorm/session_find.go:31 (0xc34244)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/models/repo_unit.go:210 (0x13f6964)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/models/repo.go:348 (0x13c4b73)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/models/repo_permission.go:186 (0x13ed2b0)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/models/repo_permission.go:142 (0x156f852)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/modules/context/repo.go:341 (0x156f7db)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/modules/context/repo.go:455 (0x157045d)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/modules/web/route.go:55 (0x1e966bb)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/go-chi/chi/mux.go:436 (0x155b4aa)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/modules/web/route.go:103 (0x1e96af6)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/modules/web/route.go:103 (0x1e96af6)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/modules/web/route.go:103 (0x1e96af6)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/go-chi/chi/middleware/get_head.go:37 (0x1eb9d81)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/modules/web/route.go:103 (0x1e96af6)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/modules/context/context.go:776 (0x157c1a9)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/go-chi/chi/mux.go:70 (0x155900a)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/go-chi/chi/mux.go:311 (0x155f3fb)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/go-chi/chi/mux.go:436 (0x155b4aa)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/routers/web/base.go:186 (0x20ce5d0)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/gitea.com/go-chi/session/session.go:256 (0x148dd6e)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/modules/public/public.go:42 (0x20a712e)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/go-chi/chi/mux.go:70 (0x155900a)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/go-chi/chi/mux.go:311 (0x155f3fb)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/go-chi/chi/mux.go:436 (0x155b4aa)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/routers/common/middleware.go:72 (0x1ebf5fd)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/routers/common/logger.go:23 (0x1ebe83b)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/go-chi/chi/middleware/strip.go:30 (0x1eba687)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/chi-middleware/proxy/middleware.go:37 (0x1eb5cee)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/routers/common/middleware.go:25 (0x1ebf13c)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/go-chi/chi/mux.go:87 (0x1558d90)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/modules/web/route.go:318 (0x1e95953)
Oct 13 20:15:54 siegetheday gitea[388734]:         code.gitea.io/gitea/vendor/github.com/gorilla/context/context.go:141 (0x1212953)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2049 (0x7c3d03)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:2867 (0x7c72c2)
Oct 13 20:15:54 siegetheday gitea[388734]:         net/http/server.go:1932 (0x7c27ec)
Oct 13 20:15:54 siegetheday gitea[388734]:         runtime/asm_amd64.s:1371 (0x47d320)
Oct 13 20:15:54 siegetheday gitea[388734]:         
Oct 13 20:15:54 siegetheday gitea[388734]: 2021/10/13 20:15:54 Completed GET /DungeonSiege/sno 500 Internal Server Error in 11.388204ms

ping @kolaente in case this is somehow a crazy distro thing (I'm not a go programmer at all so I'm a bit out of my league here).

[techknowlogick]

Panic looks like it is coming from JSONUnmarshalHandleDoubleEncode in login_source.go. Although I'll poke at it once I get to a desktop where I can actually read the above logs on a larger screen than my phone.

[zeripath]

Have you restored from a dump made by 1.14.3-1.14.6?

[aanderse]

I don't believe I have ever done a restore on this instance of gitea.

[zeripath]

Please upgrade to 1.15.4 - there is a fix to prevent an NPE at that line that was added in #17137 but you will need to reapply the patch I've provided if you still get problems so we can get more logging.

[aanderse]

Upgrading fixes the issue. Thanks to all for your help!