Skip to content

Empty envelope sender in mail notifications #17477

Closed
@pboguslawski

Description

@pboguslawski

Feature Description

Mail notifications sent by Gitea (like info about being added to repo as collaborator, checked in v1.13) have nonempty envelope sender which may generate unnecessary bounces in case of delivery problems. Now address configured in

[mailer]
FROM = Name <[email protected]>

generates messages with

Return-Path: <[email protected]>
From: Name <[email protected]>

Consider setting empty envelope sender which is allowed i.e. for bounces to avoid loops

https://datatracker.ietf.org/doc/html/rfc5321#section-4.1.1.2

With empty envelope sender messages should contain

Return-Path: <>
From: Name <[email protected]>

Not sure but places to be modified are:

https://github.com/go-gitea/gitea/blob/main/services/mailer/mailer.go#L245
https://github.com/go-gitea/gitea/blob/main/services/mailer/mailer.go#L213

Screenshots

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions