Closed
Description
This is a tracking-issue to update golangci-lint to a newer version - this is just to track which errors has to be fixed that comes up with the newer version of golangci-lint, v1.43.0.
The new update seems to catch more errors, which is always nice to have.
- Somehow update the existing installs of golangci-lint with e.g. gitea CI, otherwise it will be continue using v1.37.0 (Update golangci-lint in Makefile #17647)
- Fix the errors that present with the newer version of golangci-lint.
- SA4023 errors from staticcheck (Fix nil checking on typed interface #17598)
- offBy1 errors from gocritic (Fix offBy1 errors #17606)
- badCall errors from gocritic (Remove unnecassary calls to
filepath.Join
#17608)
- Update Makefile to download the newer version by default (Update golangci-lint in Makefile #17647)
- Remove
golint
as linter, as it's been deprecated (Removegolint
as linter #17609) - Check if we can add new added linters (Enable new golangci-linters #17610)