Error while displaying public repo (404)

[DblK]

I saw something that could be a bug (maybe Units).
If you following the procedure you will see a 404 error:

1. Create an organization with user1 (user1 is in owner team)
2. Create public repo with user1
3. Add user2 to organization but do not put him in a team
4. Access with user2 to the organization page
5. click on the repository
6. 404 error

You can also have a 404, by accessing a public repository in organization with a user not part of it.

It seems that the 404 error is triggered by routers/repo/view.go#L270.

commit: 977dcf9

[lunny]

So what's permission should a member of an organization who are not in any team have?

[pgaskin]

I had this bug too after I updated my server yesterday.

[DblK]

@lunny, depend on the type of the repo:

• If it's private none but should lead to 403 in my opinion instead of 404. (but actually I think they are not displayed)
• If it's public, all access like he is not part of the organization at all

And obviously, permit a user outside of an organization to view public repository even if not part of it.

Another way to have 404, seems #1797

[lunny]

@DblK, in fact, we need a document to describe all the permission settings we like Gitea do.

[camlafit]

Hi

In my case if an user is only organization collaborators and in any orgnization team , i can't see any organization repo.
To get repo list , it's possible only if set in organization owner team.

But in this case this user get a 404 on repo page. In log I show :

[...routers/repo/view.go:270 Home()] [E] Home: Cannot find any unit on this repository which you are allowed to acces

It's possible I've followed #1797 before (convert a personal repo to organization repo)

[lunny]

Which version did you use? I think b0308d8 has fixed that.

[camlafit]

I've just tried with master, 5min ago

On 1.1.1 it's ok

[lunny]

So a public repo of an organization should be visited by anyone? So that the units of team should be only applied for private repos of organization?

[camlafit]

If an user is set as collaborator or as member to any team (owner or not), he should be show repositories.
If a organization is public, their repositories should be public also

[lunny]

Please confirm #1812 fix this issue.

[lunny]

I think #1812 resolved this and please feel free to reopen it.