Code review tool git-appraise intergration

[lunny]

Since git-appraise will store code review data in refs/notes/devtools, gogs can read the data and show info on the web interface.

Migrated from gogs/gogs#2210

[bkcsoft]

I'll read up on git-appraise tomorrow, the README looks promising though :)

[stevenroose]

@bkcsoft You read and decided that it was too much work? :)

[bkcsoft]

It just feels like it will break very fast. How does it handle "merge-conflicts" etc?

[ojarjur]

@bkcsoft The metadata formats used by git-appraise are designed to work with the git-notes 'cat_sort_uniq' merge strategy, so merge conflicts are not an issue (they are automatically resolved by the git notes merge command).

[ojarjur]

@bkcsoft I realized a little earlier that what you were worried about with merge conflicts might have been "what happens when a comment is edited?", and that deserves a bit more details:

The formats git-appraise uses do not represent the current state of a review, but rather a log of events (e.g. "User A added a comment at line B").

This means we can automatically resolve conflicts because we can take the union of all events (this is what the 'cat_sort_uniq' strategy gives us).

However, there is a gotcha in that the current set of events does not include an 'edit comment' event (it does support 'edit review request' events).

I've filed this issue to add such support.

[stevenroose]

@ojarjur Wow, it's a real honor to have you here as the original git-appraise author! Hopefully collaboration will allow this issue to move forward more quickly!

[choucavalier]

What is the current status of this?

[lunny]

Waiting for someone send PR. :)