Unnecessary required parameter in api

[orangebokov]

Gitea Version

1.16.1

Git Version

2.20.1

Operating System

Mac OS Mojave 10.14.6

How are you running Gitea?

Via terminal command gitea

Database

MySQL

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Description

This method in api

Requires mandatory json parameter login_name

What for? The request will be executed in any case for the {username} specified in the query string.

But if I specify the wrong login_name, it will be updated, but the request will be executed anyway for {username}

Apparently, this is an extra parameter that does not affect the request in any way.

If I want to update the user's email, I can update it without passing login_name, because it will be updated for {username}

Right?

Screenshots

[stale]

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.