partial clone not working with filter

[delanym]

Description

Partial clone is not working:

/tmp/test $ git clone --filter=tree:0 git@try.gitea.io:olblak/updatecli-mirror.git tree                                                                                                                                                          18:17:34
Cloning into 'tree'...
warning: filtering not recognized by server, ignoring
remote: Enumerating objects: 7613, done.
remote: Counting objects: 100% (7613/7613), done.
remote: Compressing objects: 100% (2995/2995), done.
remote: Total 7613 (delta 4479), reused 7410 (delta 4356), pack-reused 0
Receiving objects: 100% (7613/7613), 2.11 MiB | 138.00 KiB/s, done.
Resolving deltas: 100% (4479/4479), done.
/tmp/test $ git --version                                                                                                                                                                                                                    22s 18:18:17
git version 2.37.1
/tmp/test $   

Gitea Version

1.17.0+rc1-13-g35fd55c7d built with GNU Make 4.3, go1.18.3 : bindata, timetzdata, sqlite, sqlite_unlock_notify

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

2.36.1, Wire Protocol Version 2 Enabled

Operating System

Ubuntu Linux

How are you running Gitea?

Docker-compose

Database

PostgreSQL

[Shuenhoy]

I meet the same problem. Clone filters seem to only work with HTTPS but not SSH.

[zeripath]

diff --git a/cmd/serv.go b/cmd/serv.go
index b00c3962f..3e3adb3d8 100644
--- a/cmd/serv.go
+++ b/cmd/serv.go
@@ -326,6 +326,11 @@ func runServ(c *cli.Context) error {
 	// it could be re-considered whether to use the same git.CommonGitCmdEnvs() as "git" command later.
 	gitcmd.Env = append(gitcmd.Env, git.CommonCmdServEnvs()...)
 
+	// By default partial clones are disabled, enable them from git v2.22
+	if !setting.Git.DisablePartialClone && git.CheckGitVersionAtLeast("2.22") == nil {
+		gitcmd.Env = append(gitcmd.Env, "-c", "uploadpack.allowfilter=true", "-c", "uploadpack.allowAnySHA1InWant=true")
+	}
+
 	if err = gitcmd.Run(); err != nil {
 		return fail("Internal error", "Failed to execute git command: %v", err)
 	}