Issue Template Uses Incorrect Path For Ref (Commit Instead Of Branch)

[Deadmano]

Description

When adding an issue from a template, the icon that links to the ref incorrectly wants to reference a commit instead of the branch, despite the branch existing with that same name. See the attached screenshot.

The template.md file contains:

---

name: "New Bug"
about: "Log a new bug!"
title: "Bug: "
ref: "main"
labels:

- bug

---

Expected path: /user/repo/src/branch/main
Actual path: /user/repo/src/commit/main

The actual path, which points to commit does not exist and thus results in a 404.

My understanding is that the link as per the screenshot will take you to the branch/tag as if you manually selected it when creating an issue and picking a branch/tag and the "ref" portion of the template would do exactly that. The documentation on issue templates was vague and doesn't mention what "ref" actually refers to.

Screenshots

Gitea Version

1.17.0-rc2

Can you reproduce the bug on the Gitea demo site?

No

Operating System

Windows 10

Browser Version

Firefox 102

[Deadmano]

@6543 & @lunny tagging you both as I believe I saw some things related to changes made in the latest RC that may be relevant? I could have sworn it was working prior to updating to v1.17.0-rc2, link pointing to the actual branch. I went back to 1.17.0+rc1-34-g4c1f4ee84 and the issue now still persists. Any feedback would be greatly appreciated!

[zeripath]

Have you tried?

---

name: "New Bug"
about: "Log a new bug!"
title: "Bug: "
ref: "refs/heads/main"
labels:

- bug

---

[zeripath]

If this represents a change in behaviour from 1.16 I think we should change:

gitea/modules/context/repo.go

Lines 1081 to 1088 in 599ae09

	var it api.IssueTemplate
	content, err := markdown.ExtractMetadata(string(data), &it)
	if err != nil {
	log.Debug("ExtractMetadata: %v", err)
	continue
	}
	it.Content = content
	it.FileName = entry.Name()

to prepend the refs/heads/ to the Ref if it does not match a SHA or does not already start with refs/

[Deadmano]

@zeripath that did it; you are a wonderful soul! Now what I'd love to know is why it was working prior, and updating to the latest RC seemingly broke it? I tried multiple repos, initialised both via CLI, GUI, and via the Web Interface, and it made no change to the template issue.

Is there something specific I'm meant to do when upgrading from an older install? I just shut down the instance, replaced the previous executable with the newer one, and then fired it up again.

Perhaps the documentation can be updated to explain how Ref works? I had no idea it takes a literal Git ref since the wording in the example makes it seem as if it'd point to a default main branch.

Would it then be refs/tags/{version} for tags?

[zeripath]

Was it definitely doing this other behaviour in 1.16? If so that is likely to mean that it's an unintended change of behaviour and we should implement the changes I've suggested above

[Deadmano]

It was working fine under 1.17.0+rc1-34-g4c1f4ee84 which I installed the binary gitea-1.17-windows-4.0-amd64.exe from the 1.17 downloads page. This is the first release I ever downloaded and started with.

I tried upgrading to v1.17.0-rc2 from GitHub directly using the gitea-1.17.0-rc2-windows-4.0-amd64.exe file which is when I noticed this starting to happen with my templates.

[Deadmano]

Also I noticed some strange behaviour with the pathing in the URLs.

Take for example these two paths:

/user/repo/src/brach/
/user/repo/src/commit/

If you were to enter them as per above they get malformed into:

/user/repo/src/branch/branch/main/branch
/user/repo/src/commit/branch/main/commit

Is this behaviour intended and/or related?

[zeripath]

Take for example these two paths:

What do you mean "path"? Do you mean "URL" as in:

http://gitea/user/repo/src/<some-path-that-is-not-a-branch> 

is transformed to:

http://gitea/user/repo/src/branch/master/<some-path-that-is-not-a-branch> 

If so then this is very much longstanding behaviour which has been present since before I have been submitting PRs to gitea and likely dates back to Gogs and relates to a legacy way of pointing to src files.

(Likely this should have been removed at least 3 years ago as it was legacy at that point.)

[zeripath]

OK Issue templates was in 1.16.0 so there has been an unintended change here and we should change the code above to prepend the refs/heads/ if it doesn't start with refs/.

An alternative option is to try to detect which ref this could be referring to as I suspect that people might actually want tags etc to be detected nicely.

I'm not certain.