The "all" count on a user's Pull Requests page is misleading

[parnic]

Description

When clicking around on the PRs from a user's Pull Requests page (the button in the main site header, e.g.: https://try.gitea.io/pulls), "All" is selected by default and shows the total count of all PRs in all repos.

Clicking on one of the repos, however, causes the "All" count to change to whatever is highlighted instead of showing the composite total:

I feel like All was always showing the total count in 1.16.9, but is exhibiting this behavior in 1.17.0. I am not sure if All is supposed to indicate "the number we're showing you based on your selection" or "the number we'd be showing you if you clicked on this". I tend to assume it should be the latter based on how the individual repos behave.

Gitea Version

1.17.0, 1.18.0+dev-193-g335e918b1

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Git Version

2.37.1

Operating System

Linux

How are you running Gitea?

Ubuntu apt package

Database

PostgreSQL

[noerw]

This is a regression from #20454.
The code for generating this page is complex as fuck, so I'm not suprised this regressed 😅

[lunny]

#20454

Since it's only in 1.18.0, I don't think it needs to be added to milestone 1.17.1

[parnic]

#20454

Since it's only in 1.18.0, I don't think it needs to be added to milestone 1.17.1

This bug definitely exists in 1.17.0. I logged the issue when I noticed it after our upgrade. I don't think the quoted pr is accurate for when this was introduced.

[noerw]

I don't think the quoted pr is accurate for when this was introduced.

I carefully did a git bisect, I'm certain it's that commit.

Since it's only in 1.18.0, I don't think it needs to be added to milestone 1.17.1

The change was backported to 1.17, so 1.17.1 is the appropriate target.

[lunny]

fixed by #20496