draft releases: update & delete events being sent while creation dont

[Mai-Lapyst]

Description

Pretty much what the title says: while creation events are not being sent when creating an release marked as draft, update and deletion events are, which seems counter intuitive; it should either be all sent or non of them for draft releases.

Gitea Version

1.17.2

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

linux

How are you running Gitea?

Official binary release

Database

MySQL

[delvh]

Fix has been reverted for further discussion.

[lunny]

I lost the information about why the PR has been reverted. OK. Got from #21451

We can have clarify about the logic, my proposal is

1 Creating a non-draft release -> trigger CreateRelease event
2 Creating a draft release -> no event
3 Convert a draft to a non-draft -> trigger CreateRelease event
4 Convert a non-draft to a draft -> trigger DeleteRelease event
5 Edit a non-draft release -> trigger EditRelease event
6 Edit a draft release -> no event
7 DELETE a non-draft release -> trigger DeleteRelease event
8 DELETE a draft release -> no event

[wxiaoguang]

Everything in #21451

[lunny]

I think this has been resolveded by #29008