Description
Description
All of this on Chrome, Linux, latest gitea 1.19 in try.gitea.io
Current behaviour:
When a PR contains a large file with many lines in a diff section like here (ru.po file): https://try.gitea.io/DmitryFrolovTri/issue1/pulls/1/files (file with 30k lines) but only 1.2M size
and PR reviewer goes to see the diff of the file
and tries to add a comment on a line then:
- it takes more then 1 second for the review/comment window to appear (13 sec on my machine),
- it takes more then 1 second for the text to appear after a comment been typed (5+ sec on my machine)
- any subsequent typing or editing will all be visible with a delay of more then 1 second (5+ sec on my machine)
such tremendous delay causes inability to author comments on lines of text in such way for PR reviewer.
Expected behaviour:
When a PR contains a large file with many lines in a diff section like here: https://try.gitea.io/DmitryFrolovTri/issue1/pulls/1/files
and PR reviewer goes to see the diff of the file
and tries to add a comment on a line then:
- it takes less then 1 second for the review/comment window to appear,
- it takes less then 1 second for the text to appear after a comment been typed
- any subsequent typing or editing will all be visible with a delay of less then 1 second
Please note that long loading time for the diff is ok it should take whatever it takes to load. However, once the load is done commenting is expected to work with speed that doesn't make editing complicated/long and author agitated :)
Please consider the following use case for this functionality as an example:
- reviewing a long translation file with many lines and discussing a specific translation / commenting on lines
For reproduction send me your try.gitea.io username I will add as a collaborator so comments can be tried out.
or one could create 2 branches 1 empty one , then one with such file like ru.po push them and do a PR from branch with file into the empty one, do not accept the PR, then try go to file overview in PR, load the diff, and try to put a comment on any line and that would take time
Gitea Version
Version: 1.19.0+dev-409-gc46f53a62
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
Reproduced on https://try.gitea.io
Database
None