Skip to content

Cannot reopen PR after commit #22784

Closed
@lunakiller

Description

@lunakiller

Description

If you commit to a branch of closed PR, it is not possible to reopen it and there is a notice "This pull request cannot be reopened because the branch was deleted."

Steps to reproduce:

  1. create a PR
  2. close it without merging nor deleting
  3. now commit to the branch linked in the PR
  4. PR cannot be reopened and it states the branch was deleted, even though the branch still exists (with the commit from step 3)

This was discovered on version 1.18.2 when I wanted to continue working on a PR, which was accidentally closed by my colleague, and I did not notice that. I made the changes, committed, and found out that I could not continue the PR because my branch was "deleted" even though neither I nor my colleague had done so. I tried updating to 1.18.3 and we did a simple test (same as steps above) on new branches with the same results.

Sadly, I could not reproduce the bug on the Gitea demo site due to strict network settings at my workplace. Our Gitea runs only locally behind all the firewalls, nats, proxys and whatsoever is set by our computer department.

Gitea Version

1.18.3 (also 1.18.2)

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

https://gist.github.com/lunakiller/f32476e4cbf09ae61badc37ae22088a5

Screenshots

gitea_bug_pr_closed
gitea_bug_branch

Git Version

2.39.1

Operating System

Windows 10 Enterprise

How are you running Gitea?

Prebuilt windows binary ran from cmd

Database

MySQL

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions