api gives "Internal Server Error" when creating a repo with "auto-init" set true

[brianread108]

Description

Using the swagger “Try it out” interface. I keep getting an “505 Internal Server Error” when I try and access /api/v1/user/repos, and use these parameters:

“auto_init”: true,
“default_branch”: “master”,
“description”: “a descr”,
“gitignores”: “”,
“issue_labels”: “”,
“license”: “”,
“name”: “testrepo”,
“private”: false,
“readme”: “Hello World”,
“template”: false,
“trust_model”: “default”

Seems to be the Private parameter. “true” works and “false” gives an internal Server error.
… .and also “auto_init” true gives me the Internal Server Error.

This is our own install of gitea, I can't currently see where on the web interface I can see the version number. I've asked the installer to let me have those details

Gitea Version

1.17.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

2.31.1

Operating System

Centos 8 (EL8)

How are you running Gitea?

Under proxmox in a Centos 8 VM

I am guessing MYSQL is in use

Database

MySQL

[brianread108]

Have updated the version above...

[lunny]

Please paste your logs and if you can test v1.18.3, that's better.

[brianread108]

I can switch the repo to public using the update repo api, but would not have expected that to be necessary.

[brianread108]

Please paste your logs and if you can test v1.18.3, that's better.

I've no idea how to get at the logs, I do not have command level or file level access.

We are looking at updating to 1.18.3.

[brianread108]

OK, updated to 1.18.3 and find that the "private" parameter now works to create a public repo. However I still get the failure if I set Auto-init to true.

[Zettat123]

@brianread108 Maybe the error is caused by “readme”: “Hello World”. Could you please change "Hello World" to "Default" and test again?

[brianread108]

curl -X 'POST'
'https://******/api/v1/user/repos'
-H 'accept: application/json'
-H 'Authorization: token *********************************'
-H 'Content-Type: application/json'
-d '{
"auto_init": true,
"default_branch": "master",
"description": "string",
"gitignores": "",
"issue_labels": "",
"license": "",
"name": "Test",
"private": false,
"readme": "default",
"template": false,
"trust_model": "default"
}'

Gives:

[brianread108]

and:

{
"auto_init": false,
"default_branch": "master",
"description": "string",
"gitignores": "",
"issue_labels": "",
"license": "",
"name": "Test",
"private": false,
"readme": "default",
"template": false,
"trust_model": "default"
}
gives:

[jolheiser]

I can reproduce on try when using default for the readme, as Default is the correct name and it appears to be case sensitive.

At the very least a 500 isn't correct here, we should be failing more gracefully.

[Zettat123]

as Default is the correct name and it appears to be case sensitive

Yes. The "readme" field in request is the name of readme template. The Default template is located in options/readme/Default. User could add new template to custom/options/readme/ to provide new templates for creating repos.

At the very least a 500 isn't correct here, we should be failing more gracefully.

At present, if the specified readme template does not exist, a 500 will be returned. I think a 4xx error would be better and the error message should tell user what templates are available. I will make a PR to improve it.