Admin Merge broken on 1.18.4

[gempir]

Description

I have a branch with a Branch Protection (at least 1 approval and a check that has to run)

The UI tells me I still can merge it anyway since i'm Admin. But when I try to merge it

The error message

This pull request is not ready to be merged, check review status and status checks.
Appears

Could also reproduce on try.gitea.io with [Powered by Gitea](https://gitea.io/) Version: 1.19.0+dev-521-g2b3f12f6f Page: 99ms Template: 11ms

Steps To Reproduce

• Be admin in repository
• Setup branch protection for any branch, require 1 approval
• Create a pull request pointing at the protected branch
• Try to merge without having 1 approval (with the red admin merge button)

Gitea Version

1.18.4

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Git Version

No response

Operating System

No response

How are you running Gitea?

Irrelevant

Database

None

[kolaente]

Noticed that as well.

[lunny]

@kolaente Please confirm #23010 fix this problem.

[parnic-sks]

This same issue occurs when trying to schedule an "auto-merge after checks succeed", even as a non-admin.

edit: logged this as #23022 since it seems slightly different and might not have the same fix.