File picker broken

[gempir]

Description

The file picker in a PR has a tiny height and is effectively useless. Tested on 1.19.0 was not broken on 1.19.0-rc1

Example test PR
https://try.gitea.io/gempir/gempbot/pulls/1/files

Gitea Version

1.19.0

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Git Version

No response

Operating System

No response

How are you running Gitea?

systemd

Database

None

[wxiaoguang]

It (update:expanding) works, but ....... there is a height (update:scrolling) bug 😭

I guess it's a regression of the LESS->CSS, but I can't tell the difference at the moment ..... according to #23593 (comment) , maybe there is other problem.

Add a screenshot with details for future readers.

[silverwind]

#23553 includes a fix for it (removing height: 100%, see #23553 (comment)). I don't think it's from the CSS conversion, just an edge case with many files that was not found earlier.

[gempir]

I did add screenshots, maybe they were not clear enough?

I don't really see how a PR with a scrollbar in the File Picker is an edge case to me that's a regular occurence, as we noticed this regression like 2 hours after upgrading.

[silverwind]

"Edge case" is probably not the best term, but I mean the bug does not show in all cases.

[wxiaoguang]

I did add screenshots, maybe they were not clear enough?

Sorry for bothering, at first I just thought that "expanding" doesn't work well with some height, so I confirmed again that it seems only related to the height & scrolling ..... (correct me if I am wrong)

[wxiaoguang]

I guess it's still somewhat related to the LESS->CSS (the change itself is good and right, but maybe some old bugs are triggered?) nope, it's #23554

According to my test, before: 202803f , the tree-list just works (I can't reproduce the height bug), with current main , I can 100% reproduce it .... strange.

I just don't understand what causes the problem ..... I will spend some time on it to see if we can find the root problem, to avoid other potential bugs.

---

Update: the related PR is #23554 , maybe it's not a edge case, but a regression?

[silverwind]

Yes, it is a regression from #23554 and #23553 will fix it.

[wxiaoguang]

The fix for 1.19 (#23616) has been merged.

You can get 1.19 latest from https://dl.gitea.com/gitea/1.19/ , or docker gitea:1.19-dev

These contain the fix.