Branch protection not working on Gitea 1.2.1

[lklock]

Hello,

We face an issue with the branch protection which doesn't allow to protect any branch

• Gitea version (or commit ref): 1.2.1
• Git version: 2.14.2
• Operating system: Ubuntu 16.04.3 LTS
• Database (use [x]):
  • PostgreSQL
  • [x ] MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • [x ] No
  • Not relevant
• Log gist:

Description

Most of the branches of I select are not being protected after selecting them
It works for some of them but I could not figure out any pattern (based on branch name per instance)

Example on one of our projects:

default branch set to dev-master
I can protect branch "master" but not branch"XTI-730" or "R_9_3_patches"

Are there any conditions for a branch to be able to be protected ?

[lunny]

cannot reproduce this.

[lunny]

could you show your repo settings branches UI?

[lklock]

[lklock]

[lunny]

This is not v1.2.1 I think.

[lklock]

Hi,
I've double checked it and It is version 1.2.1

[lklock]

83b894e321343e253006e689fb5a4d6fee048cf0fa3a169cb54c4060788133df gitea-1.2.1-linux-amd64

[lafriks]

Are there any error either in javascript or gitea.log?

[lklock]

No, there are no error messages neither in gitea.log or in Javascript

[lklock]

Same behavior in 1.2.2

[lafriks]

@lklock can you try to reproduce that on try.gitea.io?

[lklock]

Tried to reproduce it on try.gitea.io but it is working there with the new branch protection feature
(in my repository: BatchSystem)

[lklock]

Not so sure anymore...get lots of error 500 when I play with settings there (trying to add user to whitelist, etc...)...Don't know if it is related

[lafriks]

Can you give what errors do you get in gitea.log file

[lklock]

No, there are no error messages neither in gitea.log or in Javascript