Skip to content

"PR closed" event uses "check-circle" icon rather than "git-pull-request-closed" icon for closed and unmerged PRs #27495

Closed
@Andre601

Description

@Andre601

Description

When you close a PR without merging it, does the overview of the web-ui (The one displaying most recent activities related to you and your repositories) use the check-circle icon.

This is a rather bad choice as the icon in question implies this to be good (As in merged). Instead should the git-pull-request-closed icon be used, as it is by far the best fit.

Also, merging a PR does use the right icon (git-merge).

Screenshots

Dashboard from try.gitea.io. From bottom to top there is:

  • PR 1 being opened
  • PR 1 being closed without merge
  • PR 2 being opened
  • PR 2 being closed with merge
  • Resulting commit of the merge

grafik

Gitea Version

1.22.0+dev-125-ge3229c8e9

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

Windows

Browser Version

Firefox 118.0.1 (64-Bit)

Metadata

Metadata

Assignees

No one assigned

    Labels

    topic/uiChange the appearance of the Gitea UItype/bug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions