Caching issue is back

[somera]

Description

I see this
2023/11/14 18:23:54 models/db/context.go:178:GetByBean() [I] [SQL] SELECT "id", "setting_key", "setting_value", "version", "created", "updated" FROM "system_setting" WHERE "setting_key"=$1 LIMIT 1 [revision] - 639.796µs
when I go to my profile and start page.

I'm using memcached.

Looks like #22281

Gitea Version

1.21.1

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

2.42.0

Operating System

Ubuntu 20.04.x

How are you running Gitea?

gitea-1.21.0-linux-amd64

Database

PostgreSQL

[lunny]

How many times the query occupied?

[somera]

3289 times on the start page.

My start page needs

After the upgrade to 1.21.0. Like in #22299

[wxiaoguang]

Do you have the full log?

---

I think I know the problem now. Will propose a fix.

[wxiaoguang]

-> Fix system config cache expiration timing #28072

[somera]

Do you have the full log?

Do you still need that?

[wxiaoguang]

Do you have the full log?

Do you still need that?

Not needed now, thank you very much!

[somera]

@wxiaoguang why is the query (in my case 3228 times)

2023/11/15 18:50:28 models/db/context.go:178:GetByBean() [I] [SQL] SELECT "id", "setting_key", "setting_value", "version", "created", "updated" FROM "system_setting" WHERE "setting_key"=$1 LIMIT 1 [revision] - 984.36µs
2023/11/15 18:50:28 models/db/context.go:178:GetByBean() [I] [SQL] SELECT "id", "setting_key", "setting_value", "version", "created", "updated" FROM "system_setting" WHERE "setting_key"=$1 LIMIT 1 [revision] - 561.283µs
2023/11/15 18:50:28 models/db/context.go:178:GetByBean() [I] [SQL] SELECT "id", "setting_key", "setting_value", "version", "created", "updated" FROM "system_setting" WHERE "setting_key"=$1 LIMIT 1 [revision] - 635.435µs
2023/11/15 18:50:28 models/db/context.go:178:GetByBean() [I] [SQL] SELECT "id", "setting_key", "setting_value", "version", "created", "updated" FROM "system_setting" WHERE "setting_key"=$1 LIMIT 1 [revision] - 634.959µs

needed on the http://domain/git/org/orgname/dashboard page for every orga? For the orga list?

[wxiaoguang]

Because the "cache time" is not updated correctly, it is a bug. That's why #28072 fixes it.

[somera]

@wxiaoguang I know that this is fixed. But I try to understand why so much queries are needed on the Dashboard page for an orga. But it make no sense to show the orga list on the dashboard page.