Browsers without SubmitEvent.submitter support don't work with form-fetch-action mechanism well

[wolfbeast]

Description

I recently updated to 1.21.0 and am running into an issue now that I cannot close or re-open pull requests from the discussion page buttons at the bottom (neither with or without comment). I did not have this issue on our last version (1.19.4).

I am still able to open and close pull requests from the pull request listing (checking the boxes then clicking the close button).

I have not seen any error message be thrown in the UI.

Gitea Version

1.21.0

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Git Version

No response

Operating System

CentOS 7

How are you running Gitea?

Binary download from gitea distr. natively installed (command-line/service)

Database

MySQL/MariaDB

[lng2020]

What do you mean by Doesn't work? You can't click on it, or after clicking on it, nothing changes.

[wolfbeast]

Sorry if I wasn't clear. I can click on it, the page refreshes, but nothing changes in the status of the pull request.

I'm having the same/similar issue. It's a Draft PR with one dependency.

You need to close all issues blocking this pull request before you can merge it

Tried closing via the PR listing, but then it says

Cannot batch close issues that you choose, because issue #115487 still has open dependencies

This seems backwards, a dependency should not prevent me from closing the PR.

[wolfbeast]

I'm having the same/similar issue.

I don't think that's related. This issue occurs for me regardless of dependencies and does not throw any errors. It just reloads the page (as if the command would be processed) but the status of the PR does not change, no error given.

[wxiaoguang]

I'm having the same/similar issue.

I don't think that's related. This issue occurs for me regardless of dependencies and does not throw any errors. It just reloads the page (as if the command would be processed) but the status of the PR does not change, no error given.

Quote your issue:

Can you reproduce the bug on the Gitea demo site?

Yes

How to?

[wolfbeast]

How to?

1. edit a file in a repo on a separate branch
2. create a PR from the branch comparison
3. attempt to close the PR from the comment tab on the PR (see screenshot)

[wxiaoguang]

On try.gitea.io https://try.gitea.io/wxiaoguang/test/pulls/35

1 & 2: edit a file in a repo on a separate branch, create a PR from the branch comparison

3. attempt to close the PR from the comment tab on the PR (see screenshot)

Everything seems fine.

[wolfbeast]

I'm actually seeing the same simply with an open issue. can't close it with the button. I'll see if I can get a log.

[wxiaoguang]

Double confirm: are you sure you can reproduce it on try.gitea.io? If yes, is it browser related? If no, is it custom-template related?

[wolfbeast]

I can't see anything in our gitea log. Nothing in the browser console either. no errors on the page.

The behavior when checking the network request seems to be the following:

1. POST request to "comments"
2. response is a redirect: to the issue/pr URL.
3. POST request to /-/fetch-redirect URL.
4. response is 303 to the issue/PR page
5. GET request to the issue/PR page
6. response is the issue/PR page
   with further loading of the page

has anything in that respect changed since 1.19?