MINIMUM_KEY_SIZE_CHECK value wrongly evaluated

[karolyi]

Description

Hey,

when MINIMUM_KEY_SIZE_CHECK = true in the config (default), the UI settings will say:

Which is false. Turning the option off will place a checkmark in place of the 'option disabled' icon.

I think the configuration option is badly evaluated and thus confusing. Or the option description is worded wrongly.

Gitea Version

1.21.2

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

irrelevant

How are you running Gitea?

In a FreeBSD jail.

Database

MySQL/MariaDB

[karolyi]

I thought I understood it wrong, but it seems I still was right.

Setting the option MINIMUM_KEY_SIZE_CHECK = false will result in "Disable Minimum Key Size Check = ✗"
Turning the option MINIMUM_KEY_SIZE_CHECK = true will result in "Disable Minimum Key Size Check = ✔"

Aside from it being worded completely confusing, it's evaluated wrongly too.

[wxiaoguang]

Regression of #13860

The old code has commented out the code.

Actually IMO this code block could (should) be removed completely, because there is another code block below: