Gitea 1.21.4 adds 'user-content-' in markdown file

[makar112233]

Description

Hi.
I can't navigate through .md file in my repo, because all links in headers are converting from readme.md#_toc152597800 to readme.md#user-content-_toc152597800 and it breaks navigation through file.
I read, that it was fixed in #11903 but I can reproduce it in my local instance and in public Gitea instance: https://try.gitea.io/wenofib626/user-content/src/branch/main/readme.md

Gitea Version

1.21.4

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

2.43.0

Operating System

linux

How are you running Gitea?

Self-hosted, systemd

Database

PostgreSQL

[wxiaoguang]

Regression of Make user-content-* consistent with github #26388 @CaiCandong

Oh sorry, maybe not related .... need figure out why .... (Actually I can find a related PR for "fixing": Fix README TOC links #22577 )

[silverwind]

Keep in mind user-content- prefix is also a security precaution, because we can't allow user content to override ids on the page. The mechanism should be completely transparent to the user, e.g. hash navigation should work with and without the prefix.

[silverwind]

@makar112233 what is the exact issue? Does hash navigation not work for you? Keep note it does require having JavaScript enabled to work.

[wxiaoguang]

but I can reproduce it in my local instance and in public Gitea instance: https://try.gitea.io/wenofib626/user-content/src/branch/main/readme.md

@silverwind according to the report, and the demo on try.gitea.io, it doesn't work (neither for me).

[silverwind]

Ah yes, I can see the issue on try. Maybe something wrong in https://github.com/go-gitea/gitea/blob/main/web_src/js/markup/anchors.js or does the backend set ids that are incompatible with the JS?

[makar112233]

@silverwind
It works fine on neighbor Bitbucket server and it didn’t add “user-content” words into link.
Could you, please, help to fix it in Gitea, if it is possible? I’m not a JS or Go developer and don’t have required knowledge to be a collaborator:-(

[silverwind]

Actually no, I still don't understand what the issue is supposed to be. HTML here is

The <a> is inserted by the JS and is the "link" icon when hovering the heading. When clicking it, the page scrolls to the heading and this persists when hitting F5 as well because of the JS in initMarkupAnchors.

This behaviour is the same as GitHub, which has HTML like this:

So the only reason why those links do not work is that your browser's JS is disabled or broken and I'm pretty sure it wouldn't work on GitHub either on such a browser.

[DanielMatiasCarvalho]

Hello.

Could this issue be assigned to me? I would like to give a try at solving this.

[silverwind]

Ah I see now that the problem is about the manual TOC links

[Review](#_toc152597800)
[Staging](#_toc152597802)
[Development](#_toc152597803)
[Testing](#_toc152597828)
[Unit-tests](#_toc152597829)

Renders as

<p dir="auto"><a href="#user-content-_toc152597800" rel="nofollow">Review</a></p>
<p dir="auto"><a href="#user-content-_toc152597802" rel="nofollow">Staging</a></p>
<p dir="auto"><a href="#user-content-_toc152597803" rel="nofollow">Development</a></p>
<p dir="auto"><a href="#user-content-_toc152597828" rel="nofollow">Testing</a></p>
<p dir="auto"><a href="#user-content-_toc152597829" rel="nofollow">Unit-tests</a></p>

So we need to handle the user-content- in user-generated links in JS. Should check how GitHub does it.

[silverwind]

@DanielMatiasCarvalho give it a try. If we don't hear back, I will fix it in a couple of days.

[makar112233]

Thank you in advance, guys.