Edit file times out for large files after recent cat-file bugfix

[brechtvl]

Description

To reproduce:

• Create new new repository with Apache 2.0 license
• Click LICENSE file and Edit File
• Operation times out

Happens for any larger text file, works fine for a small file.

I bisected the cause down to #29297.

Gitea Version

1.21.6

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Running locally on Linux with own build, but also happens on try.gitea.io.

Database

None

[brechtvl]

CC @KN4CK3R as the author of this pull request.

I imagine this could affect more than just editing files.

[Joey291]

can confirm. same here

i downgraded back to 1.21.5 and working fine again.

cant open "larger" files. editor hangs and nothing loads. with bigger files i mean for example (117 lines 6.9 KiB) or (2409 lines 39 KiB)
on the other side smaller files like (27 lines 895 B) works fine

running on a docker container. official image.

[KN4CK3R]

Nice... talked about that problem in the note here #29297 (comment) Calling Close multiple times is undefined behaviour.

[KN4CK3R]

Fixed in #29354