[Bug: 1.22.0-rc1] Actions interface is replaced by errors on validation fail

[Sharaf5]

Description

when having an empty jop

• the runner is acting normally in the background
• All the site is acting normally
  except the actoins section of that repo which generates 500

I'm almost sure that there is an error handling that is missing in the interface

not to mention that this error may be generated before even listing the jops so it may be related to gitea-actions too

Screenshots

this what cased the error

notice the two jops and the unformated yml

those errors shouldn't appear here like this
the interface should tell that the file is invalid

the interface go back to normal once the jop has any decendant yml

this is a test from demo.gitea.com 1.23.0+dev-127-g2ced31e81d

Gitea Version

1.22.0-rc1, 1.23.0+dev

Can you reproduce the bug on the Gitea demo site?

Yes

Operating System

demo.gitea.com, dockerized

Browser Version

Google Chrome: 125.0.6422.112 (Official Build)

[MattSG]

I can also replicate this issue on:

Gitea Version: 1.22.0+rc1-93-g02b947a15f (gitea-1.22-nightly-gogit-windows-4.0-amd64.exe)

Steps to Reproduce:

1. Set up a fresh Gitea installation using the database option SQLite3.
2. Log in to Gitea.
3. Create a test repository.
4. Clone the repository.
5. In the cloned repository, create a .gitea/workflows directory and a README.md file within that directory to allow committing the folder structure.
6. Push these changes to the remote repository.
7. In the Gitea UI, open the test repository and use the "Add file" feature in the newly created .gitea/workflows folder to create a file named composite.yml.
8. Commit the composite.yml file.
9. Navigate to the Actions tab.
10. Observe the error that appears, which appears to persist even after refreshing the tab.

composite.yml:

on: [push]

jobs:
  jobs:
  dockerize:
    uses: ./github/workflows/dockerize.yml
    # with:
    #   registry_username: ${{secrets.REGISTRY_USERNAME}}
    #   registry_password: ${{secrets.REGISTRY_PASSWORD}}

Error observed:

An error occurred:

PANIC: runtime error: invalid memory address or nil pointer dereference
/usr/local/go/src/runtime/panic.go:770 (0x440731)
/source/modules/web/routing/logger_manager.go:116 (0x1d7bb08)
/usr/local/go/src/runtime/panic.go:770 (0x440731)
/usr/local/go/src/runtime/panic.go:261 (0x4584e6)
/usr/local/go/src/runtime/signal_windows.go:401 (0x4584b6)
/go/pkg/mod/gitea.com/gitea/act@v0.259.1/pkg/model/workflow.go:300 (0x1576905)
/source/routers/web/repo/actions/actions.go:111 (0x2813648)
/usr/local/go/src/reflect/value.go:596 (0x50b665)
/usr/local/go/src/reflect/value.go:380 (0x50a778)
/source/modules/web/handler.go:172 (0x1d8573c)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/source/modules/web/handler.go:182 (0x1d857db)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/source/modules/web/handler.go:182 (0x1d857db)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/source/modules/web/handler.go:182 (0x1d857db)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/source/modules/web/handler.go:182 (0x1d857db)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/chain.go:31 (0x1d7c565)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:459 (0x1d7f505)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/source/modules/web/handler.go:182 (0x1d857db)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/source/modules/web/handler.go:182 (0x1d857db)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/source/modules/web/handler.go:182 (0x1d857db)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/middleware/get_head.go:37 (0x26a90ad)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/source/modules/web/handler.go:136 (0x1d85bd9)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/source/modules/web/handler.go:182 (0x1d857db)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/source/services/context/context.go:225 (0x1e6374e)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/source/modules/web/handler.go:136 (0x1d85bd9)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/go/pkg/mod/gitea.com/go-chi/session@v0.0.0-20240316035857-16768d98ec96/session.go:257 (0x1d239ad)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/source/modules/web/handler.go:136 (0x1d85bd9)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:73 (0x1d7d10e)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:327 (0x1d7ea9a)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:459 (0x1d7f505)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:73 (0x1d7d10e)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:327 (0x1d7ea9a)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:459 (0x1d7f505)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/source/modules/web/routing/logger_manager.go:122 (0x1d7b9aa)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/source/modules/web/handler.go:136 (0x1d85bd9)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/go/pkg/mod/github.com/chi-middleware/proxy@v1.1.1/middleware.go:37 (0x25e3ed3)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/source/modules/web/handler.go:136 (0x1d85bd9)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/source/routers/common/middleware.go:49 (0x25e526f)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/source/modules/web/handler.go:136 (0x1d85bd9)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/source/routers/common/middleware.go:40 (0x25e4dfb)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/source/modules/web/handler.go:136 (0x1d85bd9)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/source/routers/common/middleware.go:103 (0x25e4235)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/source/modules/web/handler.go:136 (0x1d85bd9)
/usr/local/go/src/net/http/server.go:2166 (0x9fe308)
/go/pkg/mod/github.com/go-chi/chi/v5@v5.0.12/mux.go:90 (0x1d7d0cd)
/source/modules/web/route.go:163 (0x1d86fe7)
/usr/local/go/src/net/http/server.go:3137 (0xa01a0d)
/usr/local/go/src/net/http/server.go:2039 (0x9fcce7)
/usr/local/go/src/runtime/asm_amd64.s:1695 (0x47af00)
Gitea Version: 1.22.0+rc1-93-g02b947a15f

[Sharaf5]

I can't imagine that it's a ui only issue
so I also started an issue for the runner team in case it's resolvable : https://gitea.com/gitea/act_runner/issues/554
however the ui should consider the error before it's fixed for future drawback