GetCompareInfo, AddRemote: exit status 128 - error: could not lock config file config: File exists

[JulienPalard]

Description

When someone is trying to open a pull request on a repo, we're getting a 500 error :

Internal Server Error

Une erreur s’est produite:

GetCompareInfo, AddRemote: exit status 128 - error: could not lock config file config: File exists
fatal: could not set 'remote.1725953120549272064.url' to '/var/lib/gitea/data/gitea-repositories/tala/python-docs-fr.git'
 - error: could not lock config file config: File exists
fatal: could not set 'remote.1725953120549272064.url' to '/var/lib/gitea/data/gitea-repositories/tala/python-docs-fr.git'

Version de Gitea: 1.22.2

Si vous pensez qu'il s'agit d'un bug Gitea, veuillez consulter notre board [GitHub](https://github.com/go-gitea/gitea/issues) ou ouvrir un nouveau ticket si nécessaire.

On the target repo I see the lock file:

root@gitea1:~# ls -lah /var/lib/gitea/data/gitea-repositories/afpy/python-docs-fr.git
total 112K
drwxr-xr-x  8 git git 4.0K Sep 10 05:33 .
drwxr-xr-x 20 git git 4.0K Jul 23  2023 ..
-rw-r--r--  1 git git  134 Jul 26 09:04 FETCH_HEAD
-rw-r--r--  1 git git   21 Nov 17  2022 HEAD
drwxr-xr-x  2 git git 4.0K Nov 17  2022 branches
-rw-r--r--  1 git git  32K Jul 26 09:04 config
-rw-r--r--  1 git git  18K Jul 26 09:04 config.lock

Looks like the lock file is a month old.

Gitea Version

1.22.2

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

2.30.2

Operating System

Debian 11.11

How are you running Gitea?

Self hosted, installed via ansible: https://git.afpy.org/AFPy/infra/src/branch/main/roles/gitea/tasks/setup.yml

Database

PostgreSQL

[JulienPalard]

I removed the lock file and we're back on tracks, so it "works for me now" but still there's an issue causing this :D

[sbourdeauducq]

Also hitting this with Gitea 1.22.6 from nixpkgs + postgresql.

[lunny]

This issue occurs mainly when two pull requests are created simultaneously. When creating multiple pull requests, each process adds a remote to the base repository, requiring git to lock the config file. If the lock is active, the git command may exit unexpectedly due to a conflict. A potential solution could be to avoid adding a remote when creating a pull request.

[wxiaoguang]

The "one month old" lock file is left by killed git process, not by "two pull requests are created simultaneously"

Gitea needs to clean up these stale lock files

[bartvdbraak]

We are also running into this issue on a few specific repositories.

2025/04/30 09:17:00 .../web/repo/compare.go:554:ParseCompareInfo() [E] GetCompareInfo: AddRemote: exit status 128 - error: could not lock config file config: File exists
fatal: could not set 'remote.1745997420080980948.url' to '/var/lib/gitea/data/gitea-repositories/blender/blender.git'
 - error: could not lock config file config: File exists
fatal: could not set 'remote.1745997420080980948.url' to '/var/lib/gitea/data/gitea-repositories/blender/blender.git'

Cleaning up these config.lock files manually seem to have done the trick.

[lunny]

What's the path of the config.lock file?